{{ message }}
Swift: Filter more clang options not recognized by off-the-shelf clang#21992
Open
jketema wants to merge 2 commits into
Open
Swift: Filter more clang options not recognized by off-the-shelf clang#21992jketema wants to merge 2 commits into
jketema wants to merge 2 commits into
Conversation
Contributor
Sorry, something went wrong.
jketema
force-pushed
the
jketema/swift-filter
branch
2 times, most recently
from
3d1aae7 to
61fc91d
Compare
June 16, 2026 14:14
jketema
force-pushed
the
jketema/swift-filter
branch
from
61fc91d to
2eb9c54
Compare
June 16, 2026 14:57
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines Swift extraction/integration test behavior by filtering additional Apple/Xcode-specific Clang options that upstream (“off-the-shelf”) Clang may not recognize, and by excluding a synthetic file entry from an Xcode hello-world integration test.
Changes:
- Extend the Swift tracing config to strip two additional
-Xcc-prefixed Clang flags:-fobjc-msgsend-selector-stubsand-fstack-check. - Update the
hello-xcodeintegration test query to exclude files whose base name is"<module-includes>".
Show a summary per file
| File | Description |
|---|---|
| swift/tools/tracing-config.lua | Strips additional unsupported -Xcc Clang flags to reduce extractor/compiler invocation failures with non-Apple Clang. |
| swift/ql/integration-tests/osx/hello-xcode/Files.ql | Filters out the "<module-includes>" synthetic file entry from the integration test results. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
Sorry, something went wrong.
geoffw0
reviewed
Jun 16, 2026
geoffw0
left a comment
geoffw0
left a comment
Contributor
There was a problem hiding this comment.
Otherwise changes and DCA LGTM. 👍
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot code review Copilot Copilot left review comments
At least 1 approving review is required to merge this pull request.
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
DCA mostly shows wobble. The changes in the case of
SideStorelook like genuine improvements. I'm not concerned about the workflow failures, but I can re-run the DCA experiment if needed.