Shared/Python: #21935 follow up#21998
Conversation
Sorry, something went wrong.
…the dbscheme template.
…the dbscheme template.
There was a problem hiding this comment.
Pull request overview
This PR follows up on #21935 by ensuring YAML comment extraction is reflected in dbscheme sources that are generated from templates/prefixes, so affected extractors produce schemas consistent with the shared YAML libraries.
Changes:
- Add the
yaml_commentstable to the shared tree-sitter extractor dbscheme prefix. - Extend
@yaml_locatableto include@yaml_commentso comments can be associated with locations. - Mirror the same dbscheme updates in the Python extractor
dbscheme.templateto keep generated dbschemes in sync.
Show a summary per file
| File | Description |
|---|---|
| shared/tree-sitter-extractor/src/generator/prefix.dbscheme | Adds yaml_comments and updates @yaml_locatable so generated schemas support YAML comment locations. |
| python/extractor/semmle/dbscheme.template | Updates the Python extractor’s schema template to include yaml_comments and make comments locatable. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
Sorry, something went wrong.
nickrolfe
left a comment
nickrolfe
left a comment
There was a problem hiding this comment.
Looks sensible.
Sorry, something went wrong.
|
Locally, this appears to fix the problems we were observing. I'll go ahead and merge this so we can see if it fixes the problems on CI |
Sorry, something went wrong.
MathiasVP
merged commit 3dd3e2c
into
github:main
Jun 17, 2026
Reviewers
Copilot code review Copilot Copilot left review comments
In #21935 we added support for YAML comment extraction for all languages which support extraction YAML. However, it turns out there some languages generate the dbscheme from other files which I missed in that PR.
This PR fixes up these issues.