◐ Shell
reader mode source ↗
Skip to content

Drop python 3.4, prep for adding types#1188

Merged
Byron merged 7 commits into
gitpython-developers:masterfrom
Yobmod:main
Mar 3, 2021
Merged

Drop python 3.4, prep for adding types#1188
Byron merged 7 commits into
gitpython-developers:masterfrom
Yobmod:main

Conversation

@Yobmod

@Yobmod Yobmod commented Feb 28, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Drop python 3.4 in setup.py and tox.ini
  • Update .gitnignore
  • Add mypy.ini
  • Add git/py.typed file and to setup.py
  • add test/testrunner.py as a hook for monkeytype
  • Add git/types.py for type aliases and classes
  • (Some commits just formatting. VSCode switched my flake8 off for mypy)

@Yobmod

Yobmod commented Feb 28, 2021

Copy link
Copy Markdown
Contributor Author

I've had to rename testrunner.py as it was interferring with the checks. Feel free to change to a better name!

@Byron

Byron commented Mar 2, 2021

Copy link
Copy Markdown
Member

Thanks a lot! Please let me know if this is a draft (and I will make it a draft PR) or when it's ready to be merged as foundation for types (I really don't know much anything about that and rely solely on your expertise, thanks in advance for bearing my ignorance 😅).

@Yobmod

Yobmod commented Mar 2, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I think this is ready to merge as is.
It doesn't touch any of the existing code (except setup.py), but gets it all ready for adding types, whichever route we end up going for that.

@Byron Byron merged commit 20f4a9d into gitpython-developers:master Mar 3, 2021
@Byron

Byron commented Mar 3, 2021

Copy link
Copy Markdown
Member

Thanks a lot, I am looking forward to seeing the first types :)!

EliahKagan added a commit to EliahKagan/GitPython that referenced this pull request Oct 23, 2023
@EliahKagan
Add a module docstring to tstrunner.py …
e4a4186 
It benefits from a docstring because it is not referenced in code
or documentation, and its purpose is/was otherwise unclear.

The docstring includes a reference to gitpython-developers#1188 for more information.
EliahKagan added a commit to EliahKagan/GitPython that referenced this pull request Oct 23, 2023
@EliahKagan
Add a module docstring to tstrunner.py …
627b8b4 
It benefits from a docstring because it is not referenced in code
or documentation, and its purpose is/was otherwise unclear.

The docstring includes a reference to gitpython-developers#1188 for more information.
EliahKagan added a commit to EliahKagan/GitPython that referenced this pull request Oct 23, 2023
@EliahKagan
Add a module docstring to tstrunner.py …
cf9243a 
It benefits from a docstring because it is not referenced in code
or documentation, and its purpose is/was otherwise unclear.

The docstring includes a reference to gitpython-developers#1188 for more information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Yobmod @Byron