◐ Shell
reader mode source ↗
Skip to content

Fix missing stderr when the progress parameter of _clone is None#1224

Merged
Byron merged 3 commits into
gitpython-developers:mainfrom
liangjingyang:fix-missing-stderr
Apr 22, 2021
Merged

Fix missing stderr when the progress parameter of _clone is None#1224
Byron merged 3 commits into
gitpython-developers:mainfrom
liangjingyang:fix-missing-stderr

Conversation

@liangjingyang

@liangjingyang liangjingyang commented Apr 22, 2021

Copy link
Copy Markdown
Contributor

Try to fix #1221

The to_progress_instance function will convert None to RemoteProgress instance, so the line if progress_checked is True if progress parameter is None.

muggenhor
muggenhor reviewed Apr 22, 2021
View reviewed changes

@muggenhor muggenhor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks for finding this! I've created a unit test that fails without and succeeds with this change (also with only the the condition change as I suggested).

@Byron

Byron commented Apr 22, 2021

Copy link
Copy Markdown
Member

Thanks for finding this! I've created a unit test that fails without and succeeds with this change (also with only the the condition change as I suggested).

Are you able to push it into this PR? If not I would be happy to do that for you if you post it here.

@muggenhor muggenhor mentioned this pull request Apr 22, 2021
Closed
@Byron

Byron commented Apr 22, 2021

Copy link
Copy Markdown
Member

Once approved by @muggenhor this one should be ready to merge. Looks good to me (as the tests are green :) even though without the fix they are not).

@Byron Byron merged commit b85fec1 into gitpython-developers:main Apr 22, 2021
@Byron Byron added this to the v3.1.16 - Bugfixes milestone Apr 22, 2021
@Byron Byron mentioned this pull request Apr 22, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@muggenhor muggenhor muggenhor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

v3.1.16 - Bugfixes

Development

Successfully merging this pull request may close these issues.

GitCommand missing stderr

3 participants

@liangjingyang @Byron @muggenhor