◐ Shell
reader mode source ↗
Skip to content
+35 −5
Merged

Fix missing stderr when the progress parameter of _clone is None #1224

Show file tree
Hide file tree
Changes from all commits
File filter
Conversations
Jump to
Diff view
Apply and reload
Show whitespace
Diff view
Apply and reload
8 changes: 3 additions & 5 deletions git/repo/base.py
View file Edit file Delete file
Open in desktop
Original file line number Diff line number Diff line change
@@ -988,8 +988,6 @@ def init(cls, path: PathLike = None, mkdir: bool = True, odbt: Type[GitCmdObject
def _clone(cls, git: 'Git', url: PathLike, path: PathLike, odb_default_type: Type[GitCmdObjectDB],
progress: Optional[Callable], multi_options: Optional[List[str]] = None, **kwargs: Any
) -> 'Repo':
progress_checked = to_progress_instance(progress)

odbt = kwargs.pop('odbt', odb_default_type)

# when pathlib.Path or other classbased path is passed
Expand All @@ -1012,9 +1010,9 @@ def _clone(cls, git: 'Git', url: PathLike, path: PathLike, odb_default_type: Typ
if multi_options:
multi = ' '.join(multi_options).split(' ')
proc = git.clone(multi, Git.polish_url(url), clone_path, with_extended_output=True, as_process=True,
v=True, universal_newlines=True, **add_progress(kwargs, git, progress_checked))
if progress_checked:
handle_process_output(proc, None, progress_checked.new_message_handler(),
finalize_process, decode_streams=False)
else:
(stdout, stderr) = proc.communicate()
Expand Down
32 changes: 32 additions & 0 deletions test/test_clone.py
View file Edit file Delete file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
Toggle all file notes Toggle all file annotations