{{ message }}
Fix ambiguous _safer_popen_windows comment#2044
Merged
EliahKagan merged 1 commit intoJun 7, 2025
Merged
Conversation
Member
Sorry, something went wrong.
This fixes some ambiguous wording in a comment in `_safer_popen_wording`, where it was unclear if the secondary problem -- where it would be possible to run a wrong `cmd.exe`-type shell -- would happen under two separate circumstances, or only when both circumstances occurred together. This adjusts its wording to make clear that it is the latter. This also fixes a minor typo in another `_safer_popen_windows` comment. This might be viewed as building on the improvements in b9d9e56 (gitpython-developers#1859), but the changes here are to comments only.
Hide details
View details
EliahKagan
merged commit
EliahKagan
merged commit b6a188b
into
gitpython-developers:main
Jun 7, 2025
27 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
This fixes some ambiguous wording in a comment in
_safer_popen_wording, where it was unclear if the secondary problem – where it would be possible to run a wrongcmd.exe-type shell – would happen under two separate circumstances, or only when both circumstances occurred together. This adjusts its wording to make clear that it is the latter.This also fixes a minor typo in another
_safer_popen_windowscomment.This might be viewed as building on the improvements in b9d9e56 (#1859), but the changes here are to comments only.
(I'll merge this once CI passes on it.)