Allow relative path url in submodules for submodule_update#2062
Conversation
Sorry, something went wrong.
t-webber
force-pushed
the
relative_path_submodules
branch
from
545618e to
ec2e2c8
Compare
July 22, 2025 10:27
Byron
left a comment
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot for contributing!
I think with a test this can be merged. Maybe looking at the existing tests for submodules can help to set one up.
Thanks again.
Sorry, something went wrong.
Byron
left a comment
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot, this is great!
Something I'd like to also know is what happens if the submodule is 'hidden', and the URL starts with a .. This would mean the submodule resides within the parent repository, but is added as submodule under a different path.
Is this is a thing even? If you think so, please do feel free to contribute the respective test as well, but let's not block this PR on such an edge-case.
Sorry, something went wrong.
Byron
merged commit bbb3d00
into
gitpython-developers:main
Jul 24, 2025
|
I am not sure I understand your question. When you run If you try and remove the path argument, you get an error when trying to update the submodule. You have the same error if the submodule has an absolute path. Git seems to always want a path and a URL field in the |
Sorry, something went wrong.
|
Please don't mind it, it's not too important I think. Thanks again for contributing this fix and a test🙏. |
Sorry, something went wrong.
fixes #944