{{ message }}
repo, cmd: DROP UNEEDED Win path for chcwd & check for '~' homedir#529
Closed
ankostis wants to merge 1 commit into
Closed
repo, cmd: DROP UNEEDED Win path for chcwd & check for '~' homedir#529ankostis wants to merge 1 commit into
ankostis wants to merge 1 commit into
Conversation
Contributor
Sorry, something went wrong.
+ Do not abspath twice when contructing cloned repo. + Add `git.repo.base` logger.
Current coverage is 93.97% (diff: 91.66%)@@ master #529 diff @@
==========================================
Files 63 63
Lines 9628 9612 -16
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 9035 9033 -2
+ Misses 593 579 -14
Partials 0 0
|
Sorry, something went wrong.
Contributor
Author
Sorry, something went wrong.
Byron
reviewed
Oct 16, 2016
Member
|
@ankostis This looks like a massive simplification, which in any case is a good thing. Given that Appveyor will alert us of breakage, I think it is fine to go ahead with it. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
git.repo.baselogger.According to the TCs, the changes in this PR are OK.
@Byron is there any reason for not deleting this Window-only code-path about changing-cwd?