◐ Shell
reader mode source ↗
Skip to content

Remove six#581

Draft
Mic92 wants to merge 4 commits into
html5lib:masterfrom
Mic92:six
Draft

Remove six#581
Mic92 wants to merge 4 commits into
html5lib:masterfrom
Mic92:six

Conversation

@Mic92

@Mic92 Mic92 commented Sep 9, 2024

Copy link
Copy Markdown

Depends on #580

Mic92 added 4 commits September 9, 2024 10:16
@Mic92
ruff: pyupgrade to 3.8 …
ef4c5ce 
ruff check --target-version py38 --select UP --fix .
@Mic92
manually remove fallback imports
fb864a9
@Mic92
only support pythons that are not EOL (https://endoflife.date/python) …
29d3072 
Even debian oldstable has python 3.9. For internet-facing libraries it
is not secure for contributor to install unsupported python versions in order to test them.
Reducing the number of python versions will make maintenance and testing easier.
is not secure to contributor to install unsupported python versions in order to test them.
@Mic92
remove six
f90ee80
@Mic92

Mic92 commented Sep 9, 2024

Copy link
Copy Markdown
Author

I will continue to look at this when #580 is merged. Currently it still has some errors in it.

@ashleysommer

ashleysommer commented Sep 25, 2024

Copy link
Copy Markdown

Hi @Mic92
I am pulling this PR (and #580) into a custom html5lib fork for my personal project.
Can you tell me what errors you are still seeing after these commits?

@ashleysommer ashleysommer mentioned this pull request Sep 25, 2024
Merged
@ashleysommer

ashleysommer commented Sep 25, 2024

Copy link
Copy Markdown

@Mic92 I found two, on line 133 and 135 of _inputstream.py you need to replace text_type with str.
After doing that, all tests pass.

@Mic92

Mic92 commented Sep 25, 2024

Copy link
Copy Markdown
Author

I was mainly looking at the test suite failing.

@Mic92

Mic92 commented Sep 25, 2024

Copy link
Copy Markdown
Author

Good to know there is a potential fork to switch to in the future.

@ashleysommer

ashleysommer commented Sep 25, 2024 •
edited
Loading

Copy link
Copy Markdown

Good to know there is a potential fork to switch to in the future.

@Mic92
Its now published here:
https://pypi.org/project/html5lib-modern/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mic92 @ashleysommer