◐ Shell
reader mode source ↗
Skip to content

Formbased authentication corrupts post params payara#429

Open
albfernandez wants to merge 3 commits into
javaee-samples:masterfrom
albfernandez:formbased_authentication_corrupts_post_params_payara
Open

Formbased authentication corrupts post params payara#429
albfernandez wants to merge 3 commits into
javaee-samples:masterfrom
albfernandez:formbased_authentication_corrupts_post_params_payara

Conversation

@albfernandez

@albfernandez albfernandez commented Jan 28, 2018

Copy link
Copy Markdown

This testcase reproduces Payara bug

payara/Payara#2318

@albfernandez
First attemp to reproduce parameter corruption in Payara …
69d8b87 
See payara/Payara#2318 for mor details.

I've reproduced the bug in Payara 4.1.2.174, but this first version on
Arquillian works as expected.
@albfernandez
Fix the test to reproduce payara bug …
3a557d5 
payara/Payara#2318
@albfernandez albfernandez mentioned this pull request Jan 28, 2018
Merged
@albfernandez

albfernandez commented Jan 29, 2018

Copy link
Copy Markdown
Author

The failing test is the expected behaviour: It's the payara bug we're trying to reproduce

Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 23.829 sec <<< FAILURE! - in org.javaee7.servlet.security.form.based.FormTest
testMaintainPostParamsAfterAuth(org.javaee7.servlet.security.form.based.FormTest) Time elapsed: 0.474 sec <<< FAILURE!
org.junit.ComparisonFailure: expected:<[7]> but was:<[251]>
at org.javaee7.servlet.security.form.based.FormTest.testMaintainPostParamsAfterAuth(FormTest.java:108)

@arjantijms

arjantijms commented Jan 30, 2018

Copy link
Copy Markdown
Contributor

Looks good, will pull in as soon as we have the fix for Payara in. Thx!

@albfernandez

albfernandez commented Nov 17, 2018

Copy link
Copy Markdown
Author

This sample should pass the test now ,
from the pom.xml <payara.version>4.1.2.181</payara.version>, version which fixed de bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@albfernandez @arjantijms