◐ Shell
reader mode source ↗
Skip to content

Comparisons#101

Merged
mahdyar merged 7 commits into
javascript-tutorial:masterfrom
emadpoursina:master
Mar 30, 2021
Merged

Comparisons#101
mahdyar merged 7 commits into
javascript-tutorial:masterfrom
emadpoursina:master

Conversation

@emadpoursina

@emadpoursina emadpoursina commented Mar 28, 2021

Copy link
Copy Markdown
Contributor

Translation is done. Please review and commit if anything is wrong.

@emadpoursina
Translate aticle.md …
5c7b168 
Translation is done. Please review and commit if anything is wrong.
@javascript-translate-bot javascript-translate-bot requested a review from a team March 28, 2021 06:37
mahdyar
mahdyar requested changes Mar 28, 2021
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Hello @emadpoursina,
First, you should claim the article in #1.
Also, read the For New Translators section there (#1):

The pull request title should be same as the article, e.g. An Introduction to JavaScript (just like comment)

@javascript-translate-bot

javascript-translate-bot commented Mar 28, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@emadpoursina emadpoursina changed the title Translate aticle.md Mar 28, 2021
@emadpoursina

emadpoursina commented Mar 28, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

/done

mahdyar
mahdyar requested changes Mar 28, 2021
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

There is a folder which contains the tasks and solutions that should also be translated.

@javascript-translate-bot

javascript-translate-bot commented Mar 28, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@emadpoursina

emadpoursina commented Mar 28, 2021

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team March 28, 2021 13:41
@javascript-translate-bot

javascript-translate-bot commented Mar 28, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@emadpoursina

emadpoursina commented Mar 30, 2021

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team March 30, 2021 03:19
@mahdyar mahdyar merged commit 457ca0b into javascript-tutorial:master Mar 30, 2021
@javascript-translate-bot javascript-translate-bot mentioned this pull request Mar 30, 2021
Open
@javascript-translate-bot

javascript-translate-bot commented Mar 30, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emadpoursina @javascript-translate-bot @mahdyar