◐ Shell
reader mode source ↗
Skip to content

Loops: while and for#103

Merged
mahdyar merged 24 commits into
javascript-tutorial:masterfrom
mahdiHash:master
Mar 30, 2021
Merged

Loops: while and for#103
mahdyar merged 24 commits into
javascript-tutorial:masterfrom
mahdiHash:master

Conversation

@mahdiHash

Copy link
Copy Markdown
Contributor

Please read the description of task 7 "list primes"
Translation of "article.md" was a little tricky and some parts of translation may be weird so please review and comment / commit if you have anything better in mind

line 11: `i++` -> `++i`  because it is `پیشوند`

line 18: `++i` -> `i++`  because it is `پسوند`
Please review and comment / commit if anything is wrong
Please review and comment / commit if anything is wrong
Please review and comment / commit if anything is wrong
Please review and comment / commit if anything is wrong
Please review and comment / commit if anything is wrong
Please review and comment / commit if anything is wrong
Please review and comment / commit if anything is wrong
Please review and comment / commit if anything is wrong
Please review and comment / commit if anything is wrong
I'm not sure of line 17 translation.
Please review and comment / commit if it could be better or anything is wrong
Changed `می شود` to `شده` for reading purposes.
The translation was a little tricky so please review and comment / commit if anything is wrong.
Changed "میشود" to "می شود"
Changed "میشود" to "می شود"
3 hidden conversations Load more…
@javascript-translate-bot

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All the mentioned problems are fixed and I also changed some lines to make it more readable
@mahdiHash

Copy link
Copy Markdown
Contributor Author

Thank you @mahdyar for your review

@mahdiHash

Copy link
Copy Markdown
Contributor Author

/done

@mahdyar mahdyar merged commit daf19aa into javascript-tutorial:master Mar 30, 2021
@javascript-translate-bot

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants