◐ Shell
reader mode source ↗
Skip to content

polyfills and transpilers#104

Merged
mahdyar merged 7 commits into
javascript-tutorial:masterfrom
newshahn:master
Apr 5, 2021
Merged

polyfills and transpilers#104
mahdyar merged 7 commits into
javascript-tutorial:masterfrom
newshahn:master

Conversation

@newshahn

@newshahn newshahn commented Apr 3, 2021

Copy link
Copy Markdown
Contributor

polyfills and transpilers is done.

@javascript-translate-bot javascript-translate-bot requested a review from a team April 3, 2021 09:40
mahdyar
mahdyar requested changes Apr 3, 2021
View reviewed changes
2 hidden conversations Load more…
@javascript-translate-bot

javascript-translate-bot commented Apr 3, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@newshahn newshahn requested a review from mahdyar April 3, 2021 11:30
@newshahn

newshahn commented Apr 3, 2021

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team April 3, 2021 11:30
mahdyar
mahdyar requested changes Apr 3, 2021
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Hello @newshahn,
Please read the Translation Tips:

Please keep line breaks and paragraphs "as is": don't add newlines and don't remove existing ones. Makes it easy to merge future changes from the English version into the translation.

You can see the difference in Files changed section, line numbers on both sides should be the same.

@javascript-translate-bot

javascript-translate-bot commented Apr 3, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@newshahn

newshahn commented Apr 4, 2021

Copy link
Copy Markdown
Contributor Author

Sorry about all the mistakes.
Hopefully they're fixed now.
/done

@javascript-translate-bot javascript-translate-bot requested a review from a team April 4, 2021 07:48
mahdyar
mahdyar requested changes Apr 4, 2021
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Also add a newline at the end of the file.

@javascript-translate-bot

javascript-translate-bot commented Apr 4, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@newshahn

newshahn commented Apr 5, 2021

Copy link
Copy Markdown
Contributor Author

😟
👀

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team April 5, 2021 13:08
mahdyar
mahdyar approved these changes Apr 5, 2021
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thank you, @newshahn!

@mahdyar mahdyar merged commit 6757403 into javascript-tutorial:master Apr 5, 2021
@mahdyar mahdyar mentioned this pull request Apr 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@newshahn @javascript-translate-bot @mahdyar