◐ Shell
reader mode source ↗
Skip to content

Modules, introduction#106

Merged
mahdyar merged 4 commits into
javascript-tutorial:masterfrom
emadpoursina:master
Apr 9, 2021
Merged

Modules, introduction#106
mahdyar merged 4 commits into
javascript-tutorial:masterfrom
emadpoursina:master

Conversation

@emadpoursina

@emadpoursina emadpoursina commented Apr 5, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team April 5, 2021 14:18
mahdyar
mahdyar requested changes Apr 5, 2021
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Hello @emadpoursina,
Please read the For New Translators section there (#1):

The pull request title should be same as the article, e.g. An Introduction to JavaScript (just like comment)

@javascript-translate-bot

javascript-translate-bot commented Apr 5, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@emadpoursina emadpoursina changed the title translate article.md Apr 6, 2021
@emadpoursina

emadpoursina commented Apr 6, 2021

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team April 6, 2021 02:39
@javascript-translate-bot

javascript-translate-bot commented Apr 6, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@emadpoursina

emadpoursina commented Apr 6, 2021

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team April 6, 2021 08:27
@javascript-translate-bot

javascript-translate-bot commented Apr 6, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@emadpoursina

emadpoursina commented Apr 6, 2021

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team April 6, 2021 12:00
@javascript-translate-bot

javascript-translate-bot commented Apr 6, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@emadpoursina

emadpoursina commented Apr 9, 2021

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team April 9, 2021 09:36
mahdyar
mahdyar approved these changes Apr 9, 2021
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thank you, @emadpoursina!

@mahdyar mahdyar merged commit 6e092bb into javascript-tutorial:master Apr 9, 2021
@javascript-translate-bot javascript-translate-bot mentioned this pull request Apr 9, 2021
Open
@javascript-translate-bot

javascript-translate-bot commented Apr 9, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emadpoursina @javascript-translate-bot @mahdyar