◐ Shell
reader mode source ↗
Skip to content

Mouse events#149

Merged
mahdyar merged 6 commits into
javascript-tutorial:masterfrom
erfanyeganegi:mouse-event-basics
Sep 11, 2021
Merged

Mouse events#149
mahdyar merged 6 commits into
javascript-tutorial:masterfrom
erfanyeganegi:mouse-event-basics

Conversation

@erfanyeganegi

@erfanyeganegi erfanyeganegi commented Sep 10, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team September 10, 2021 07:51
@mahdyar mahdyar changed the title mouse-event-basics Sep 10, 2021
@mahdyar mahdyar mentioned this pull request Sep 10, 2021
Open
mahdyar
mahdyar requested changes Sep 10, 2021
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Hello @erfanyeganegi and thank you for your contribution!
Please consider naming your PR after the article name for future PRs (Read the readme if you haven't):

PR title should match article title, the bot will write it's number into the issue.

@javascript-translate-bot

javascript-translate-bot commented Sep 10, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@erfanyeganegi
Update index.html …
18e169c 
make the requested changes.
@erfanyeganegi
Revert "mouse-event-basics" …
7927eae 
This reverts commit 255c30a.
@erfanyeganegi
Update article.md …
65a7114 
made the requested changes and improved translation.
@erfanyeganegi
requested changes done
550e42c
@erfanyeganegi

erfanyeganegi commented Sep 10, 2021

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team September 10, 2021 10:04
mahdyar
mahdyar requested changes Sep 10, 2021
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I mentioned some of the problems below, please check it again for any similar problems.
Line numbers shouldn't change.

@javascript-translate-bot

javascript-translate-bot commented Sep 10, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@erfanyeganegi

erfanyeganegi commented Sep 10, 2021

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team September 10, 2021 20:15
mahdyar
mahdyar approved these changes Sep 11, 2021
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thank you, @erfanyeganegi!

@mahdyar mahdyar merged commit c0c5540 into javascript-tutorial:master Sep 11, 2021
@javascript-translate-bot

javascript-translate-bot commented Sep 11, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@erfanyeganegi erfanyeganegi deleted the mouse-event-basics branch September 11, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erfanyeganegi @javascript-translate-bot @mahdyar