◐ Shell
reader mode source ↗
Skip to content

Searching: getElement*, querySelector*#278

Merged
mahdiHash merged 37 commits into
javascript-tutorial:masterfrom
shahrzadJavadiKoushesh:patch-2
Jul 31, 2023
Merged

Searching: getElement*, querySelector*#278
mahdiHash merged 37 commits into
javascript-tutorial:masterfrom
shahrzadJavadiKoushesh:patch-2

Conversation

@shahrzadJavadiKoushesh

@shahrzadJavadiKoushesh shahrzadJavadiKoushesh commented Jul 16, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team July 16, 2023 17:47
@CLAassistant

CLAassistant commented Jul 16, 2023 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@javascript-translate-bot javascript-translate-bot mentioned this pull request Jul 16, 2023
Open
alivarastepour
alivarastepour suggested changes Jul 17, 2023
View reviewed changes

@alivarastepour alivarastepour left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

please re-format your translation so that the number of lines match the number of lines in the original version. comment /done when done.

25 hidden items Load more…
@javascript-translate-bot

javascript-translate-bot commented Jul 22, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@shahrzadJavadiKoushesh

shahrzadJavadiKoushesh commented Jul 23, 2023

Copy link
Copy Markdown
Contributor Author

Hi, you have forgotten to merge your changes to the current branch; also note that top file metadata should not be translated.

/done

alivarastepour
alivarastepour suggested changes Jul 23, 2023
View reviewed changes

@alivarastepour alivarastepour left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Hello again,
First of all, thanks for your contribution and time devoted to this project;
As you have probably guessed, using markdown with two languages which have different directions is a bit challenging; so we kindly ask you to follow the steps mentioned in this repo to bring a local server up and see your changes as they are made to each individual markdown.
all changes should maintain the readability of document; currently, that is not the case with your changes.
Thanks again

@javascript-translate-bot

javascript-translate-bot commented Jul 23, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@mahdiHash

mahdiHash commented Jul 25, 2023

Copy link
Copy Markdown
Contributor

Hello again, First of all, thanks for your contribution and time devoted to this project; As you have probably guessed, using markdown with two languages which have different directions is a bit challenging; so we kindly ask you to follow the steps mentioned in this repo to bring a local server up and see your changes as they are made to each individual markdown. all changes should maintain the readability of document; currently, that is not the case with your changes. Thanks again

Checking the translation with the server repo isn't that necessary. You can read the article on github since it'll keep the RTL format of Persian (although in some cases it's overridden, but it's ok overall).
So, please submit your review on this translation, @alivarastepour.

alivarastepour
alivarastepour suggested changes Jul 27, 2023
View reviewed changes

@alivarastepour alivarastepour left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Hi @shahrzadJavadiKoushesh , i have proposed some changes to improve your translation even further. please review them.

@javascript-translate-bot

javascript-translate-bot commented Jul 27, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@mahdiHash

mahdiHash commented Jul 28, 2023

Copy link
Copy Markdown
Contributor

Thanks for the review, @alivarastepour :D

@shahrzadJavadiKoushesh

shahrzadJavadiKoushesh commented Jul 30, 2023

Copy link
Copy Markdown
Contributor Author

/done

mahdyar
mahdyar approved these changes Jul 30, 2023
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM!

@mahdiHash

mahdiHash commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

Thanks for your contribution, @shahrzadJavadiKoushesh :D

@mahdiHash mahdiHash merged commit 950fd4b into javascript-tutorial:master Jul 31, 2023
@javascript-translate-bot

javascript-translate-bot commented Jul 31, 2023

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar

+2 more reviewers

@mahdiHash mahdiHash mahdiHash approved these changes

@alivarastepour alivarastepour alivarastepour approved these changes

Assignees

@mahdiHash mahdiHash

@alivarastepour alivarastepour

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@shahrzadJavadiKoushesh @CLAassistant @javascript-translate-bot @mahdiHash @alivarastepour @mahdyar