◐ Shell
reader mode source ↗
Skip to content

Functions#75

Open
rskhan167 wants to merge 41 commits into
javascript-tutorial:masterfrom
rskhan167:master
Open

Functions#75
rskhan167 wants to merge 41 commits into
javascript-tutorial:masterfrom
rskhan167:master

Conversation

@rskhan167

Copy link
Copy Markdown
Contributor

I have translated Functions. Please let me know if there are any changes/modifications needed. Thank you.

@CLAassistant

CLAassistant commented Sep 9, 2021

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@theBstar theBstar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Can you have look at all the comments? Also have a re-look at the 1-js/02-first-steps/15-function-basics/article.md file, haven't review all of it. Needs some re-work. Thanks for the contribution. As you are maintaining the project now if you feel something is good enough to be merged feel free to merged even without another review. But make sure you do a proper self-review. Key here to just read the Hindi version and see if everything makes sense. After which you can read the English and Hindi side by side, to check for keywords and other guidelines. Thanks

@javascript-translate-bot

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

8 hidden items Load more…
@rskhan167

Copy link
Copy Markdown
Contributor Author

/done

@rskhan167

Copy link
Copy Markdown
Contributor Author

Can you have look at all the comments? Also have a re-look at the 1-js/02-first-steps/15-function-basics/article.md file, haven't review all of it. Needs some re-work. Thanks for the contribution. As you are maintaining the project now if you feel something is good enough to be merged feel free to merged even without another review. But make sure you do a proper self-review. Key here to just read the Hindi version and see if everything makes sense. After which you can read the English and Hindi side by side, to check for keywords and other guidelines. Thanks

Thanks for the review. I have made the requested changes also I have gone through 1-js/02-first-steps/15-function-basics/article.md file and made some changes there too. Please let me know if the changes are correct or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants