◐ Shell
reader mode source ↗
Skip to content

Comments#77

Merged
rskhan167 merged 6 commits into
javascript-tutorial:masterfrom
Deep1Shikha:patch-1
Sep 23, 2021
Merged

Comments#77
rskhan167 merged 6 commits into
javascript-tutorial:masterfrom
Deep1Shikha:patch-1

Conversation

@Deep1Shikha

@Deep1Shikha Deep1Shikha commented Sep 14, 2021

Copy link
Copy Markdown
Contributor

Comments

@Deep1Shikha
Comments …
b6f3119 
Comments
@javascript-translate-bot javascript-translate-bot requested a review from a team September 14, 2021 15:41
@CLAassistant

CLAassistant commented Sep 14, 2021 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@javascript-translate-bot javascript-translate-bot mentioned this pull request Sep 14, 2021
Open
@rskhan167 rskhan167 requested review from rskhan167 and removed request for rskhan167 September 15, 2021 05:17
rskhan167
rskhan167 reviewed Sep 15, 2021
View reviewed changes

@rskhan167 rskhan167 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

These are some changes required please address these. And let me know if you need any help. Thanks.

@Deep1Shikha
Update article.md …
2434c78 
Updated as per review
@Deep1Shikha
Update article.md …
490924c 
Implemented changes for first review comment
@Deep1Shikha

Deep1Shikha commented Sep 15, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for the suggestions, I have pushed the changes.

@javascript-translate-bot

javascript-translate-bot commented Sep 15, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@rskhan167

rskhan167 commented Sep 15, 2021

Copy link
Copy Markdown
Contributor

Thanks for the suggestions, I have pushed the changes.

A few more change requests have been added. Please address those too. Thanks.

@Deep1Shikha
Comments …
7f09965 
Comments /done
8 hidden items Load more…
@Deep1Shikha

Deep1Shikha commented Sep 15, 2021

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team September 15, 2021 09:45
rskhan167
rskhan167 requested changes Sep 15, 2021
View reviewed changes

@rskhan167 rskhan167 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Everything looks good. There is this one change I found. After this I think it is ready to get merged.

@javascript-translate-bot

javascript-translate-bot commented Sep 15, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@Deep1Shikha
Comments …
90a54a1 
Comments updated
@Deep1Shikha

Deep1Shikha commented Sep 17, 2021

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team September 17, 2021 12:52
rskhan167
rskhan167 requested changes Sep 17, 2021
View reviewed changes

@rskhan167 rskhan167 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

It seems you forgot to change वास्तुकला to संरचना at other place. Please change that and request review

@javascript-translate-bot

javascript-translate-bot commented Sep 17, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@Deep1Shikha
Comments …
62f65ab 
Updated changes as per suggestions
@javascript-translate-bot javascript-translate-bot requested a review from a team September 22, 2021 18:11
@Deep1Shikha Deep1Shikha requested review from rskhan167 and removed request for a team September 23, 2021 14:24
@Deep1Shikha

Deep1Shikha commented Sep 23, 2021

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team September 23, 2021 14:24
@rskhan167

rskhan167 commented Sep 23, 2021

Copy link
Copy Markdown
Contributor

Good work @Deep1Shikha , thanks for contributing. I am merging this PR. Hoping to see many more contributions from you. And Please let your friends and colleagues also know about this project. Thanks 👍

@rskhan167 rskhan167 merged commit b90bfda into javascript-tutorial:master Sep 23, 2021
@javascript-translate-bot

javascript-translate-bot commented Sep 23, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@Deep1Shikha

Deep1Shikha commented Sep 23, 2021

Copy link
Copy Markdown
Contributor Author

Thank you! I am equally enthusiastic and glad. This was my first contribution and it has been merged. I will continue contributing. Grateful to you for your reviews. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rskhan167 rskhan167 Awaiting requested review from rskhan167

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Deep1Shikha @CLAassistant @javascript-translate-bot @rskhan167