◐ Shell
reader mode source ↗
Skip to content

The modern mode, "use strict"#83

Open
DKumar2169 wants to merge 5 commits into
javascript-tutorial:masterfrom
DKumar2169:master
Open

The modern mode, "use strict"#83
DKumar2169 wants to merge 5 commits into
javascript-tutorial:masterfrom
DKumar2169:master

Conversation

@DKumar2169

@DKumar2169 DKumar2169 commented Oct 15, 2021

Copy link
Copy Markdown

Made some changes Please review if I did this correct so I can work on it more

@javascript-translate-bot javascript-translate-bot requested a review from a team October 15, 2021 12:44
@CLAassistant

CLAassistant commented Oct 15, 2021 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@rskhan167 rskhan167 changed the title Update article.md Oct 16, 2021
rskhan167
rskhan167 requested changes Oct 16, 2021
View reviewed changes

@rskhan167 rskhan167 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks for submitting the PR. Good work, there's a few changes then we are good to go.
Also, please don't add or remove any line, a couple of places I have added a remark to remove extra line please compare with original file and check in other places too. Thanks.

4 hidden conversations Load more…
@javascript-translate-bot

javascript-translate-bot commented Oct 16, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

DKumar2169
DKumar2169 commented Oct 17, 2021
View reviewed changes

@DKumar2169 DKumar2169 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Changes have been made

@DKumar2169 DKumar2169 closed this Oct 19, 2021
@DKumar2169 DKumar2169 reopened this Oct 19, 2021
@rskhan167

rskhan167 commented Oct 26, 2021

Copy link
Copy Markdown
Contributor

Hi @DKumar2169, I have reviewed your PR. Great work, it looks good. There were few changes needed like removal of extra space and line. I have committed those changes. Please have a look at it and let me know if anything needs to be changed. Then, we can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rskhan167 rskhan167 rskhan167 requested changes

Assignees

No one assigned

Labels

changes requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DKumar2169 @CLAassistant @javascript-translate-bot @rskhan167