◐ Shell
reader mode source ↗
Skip to content

Variables#151

Merged
bogdanbacosca merged 33 commits into
javascript-tutorial:masterfrom
Alexandra2888:Variables
Dec 6, 2022
Merged

Variables#151
bogdanbacosca merged 33 commits into
javascript-tutorial:masterfrom
Alexandra2888:Variables

Conversation

@Alexandra2888

@Alexandra2888 Alexandra2888 commented Dec 1, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team December 1, 2022 19:14
@javascript-translate-bot javascript-translate-bot mentioned this pull request Dec 1, 2022
Open
@CLAassistant

CLAassistant commented Dec 1, 2022 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

bogdanbacosca
bogdanbacosca requested changes Dec 1, 2022
View reviewed changes

@bogdanbacosca bogdanbacosca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Excelent, mai avem doar putin de lustruit la el și după este gata pentru merge.
Rog doar să vă mai uitați odata la ordinea liniilor și să țineți cont de recomandari.

@javascript-translate-bot

javascript-translate-bot commented Dec 1, 2022

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@Alexandra2888

Alexandra2888 commented Dec 2, 2022

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team December 2, 2022 12:40
bogdanbacosca
bogdanbacosca requested changes Dec 2, 2022
View reviewed changes

@bogdanbacosca bogdanbacosca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Trebuie verificat și răspuns la sugestii.

@javascript-translate-bot

javascript-translate-bot commented Dec 2, 2022

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

24 hidden items Load more…
@Alexandra2888

Alexandra2888 commented Dec 3, 2022

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team December 3, 2022 19:35
bogdanbacosca
bogdanbacosca requested changes Dec 3, 2022
View reviewed changes

@bogdanbacosca bogdanbacosca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Trebuie să ținem cont de sugestii înainte să trimitem codul înapoi.

23 hidden conversations Load more…
@javascript-translate-bot

javascript-translate-bot commented Dec 3, 2022

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@Alexandra2888

Alexandra2888 commented Dec 3, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Acestea nu mi-au aparut chiar daca am dat See hidden. O sa le rezolv.

@bogdanbacosca

bogdanbacosca commented Dec 3, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

@Alexandra2888 Nu erau acolo înainte, le-am adăugat la ultimul review. Au fost lucruri repetitive și nu le-am marcat pe toate de la început.

@Alexandra2888

Alexandra2888 commented Dec 5, 2022

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team December 5, 2022 20:23
@bogdanbacosca
final polish …
3609555 
Translated smart headers and other minor improvements.
@bogdanbacosca
minor fix
0832fdf
@bogdanbacosca
sync main …
13da2ca 
synced with main repo and translated
@bogdanbacosca
minor improvement
e9dcaf3
@bogdanbacosca
minor update
873c53f
@bogdanbacosca
minor update
14c9aa4
bogdanbacosca
bogdanbacosca approved these changes Dec 6, 2022
View reviewed changes

@bogdanbacosca bogdanbacosca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Am făcut câteva modificări și adaosuri minore înainte de aprobare, ținând cont că deja s-a lucrat destul de mult la acest PR.
Un detaliu de reținut pentru viitor - putem traduce și conținutul din smart header.
De asemenea, trebuie să fim atenți la cele mai mici detalii: de la liniile din cod până la formatarea codului și spațiile dintre caractere.
PR aprobat.

@bogdanbacosca bogdanbacosca merged commit 986cf62 into javascript-tutorial:master Dec 6, 2022
@javascript-translate-bot

javascript-translate-bot commented Dec 6, 2022

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bogdanbacosca bogdanbacosca

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Alexandra2888 @CLAassistant @javascript-translate-bot @bogdanbacosca