◐ Shell
reader mode source ↗
Skip to content

Functions#169

Open
marina-t-itf wants to merge 7 commits into
javascript-tutorial:masterfrom
marina-t-itf:master
Open

Functions#169
marina-t-itf wants to merge 7 commits into
javascript-tutorial:masterfrom
marina-t-itf:master

Conversation

@marina-t-itf

@marina-t-itf marina-t-itf commented Jan 18, 2023

Copy link
Copy Markdown

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team January 18, 2023 16:39
@javascript-translate-bot javascript-translate-bot mentioned this pull request Jan 18, 2023
Open
@CLAassistant

CLAassistant commented Jan 18, 2023 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ marina-t-itf
✅ bogdanbacosca
❌ MarinaG

MarinaG seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

bogdanbacosca
bogdanbacosca requested changes Jan 20, 2023
View reviewed changes

@bogdanbacosca bogdanbacosca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Mai sunt câteva schimbări minore care trebuiesc implementate.

25 hidden conversations Load more…
@javascript-translate-bot

javascript-translate-bot commented Jan 20, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

marina-t-itf
marina-t-itf commented Jan 24, 2023
View reviewed changes

@marina-t-itf marina-t-itf left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Done

bogdanbacosca
bogdanbacosca requested changes Jan 25, 2023
View reviewed changes

@bogdanbacosca bogdanbacosca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Încă puține modificări minore.

@javascript-translate-bot

javascript-translate-bot commented Jan 25, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@bogdanbacosca

bogdanbacosca commented Jan 25, 2023

Copy link
Copy Markdown
Contributor

@marina-t-itf Am rezolvat câteva merge conflicts, sunt câteva bucăți netraduse adăugate.

marina-t-itf
marina-t-itf commented Jan 25, 2023
View reviewed changes

@marina-t-itf marina-t-itf left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Done

@marina-t-itf

marina-t-itf commented Jan 25, 2023 via email

Copy link
Copy Markdown
Author

bogdanbacosca
bogdanbacosca requested changes Jan 25, 2023
View reviewed changes

@bogdanbacosca bogdanbacosca left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Sunt câteva comentarii care nu au fost adresate și bucăți netraduse (care au fost introduse cand am rezolvat acel merge conflict)
Am găsit și câteva ghilimele formatate greșit.

@javascript-translate-bot

javascript-translate-bot commented Jan 25, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

bogdanbacosca
bogdanbacosca requested changes Mar 4, 2023
View reviewed changes

@bogdanbacosca bogdanbacosca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Avem câteva bucăți netraduse, o linie în plus, am modifical fals cu falsy pentru că este un termen tehnic, am modificat în unele părți transmis în loc de trecut (pentru consistență).
Vezi toate comentariile pentru mai multe detalii.
Mulțumesc pentru PR 👍 😄
Încă putine modificări și este gata.

23 hidden conversations Load more…
@javascript-translate-bot

javascript-translate-bot commented Mar 4, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@marina-t-itf marina-t-itf reopened this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bogdanbacosca bogdanbacosca bogdanbacosca requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marina-t-itf @CLAassistant @javascript-translate-bot @bogdanbacosca