◐ Shell
reader mode source ↗
Skip to content

Functions#127

Merged
tarasyyyk merged 16 commits into
javascript-tutorial:function-basicsfrom
hypeofpipe:first-steps/function-basics
Jul 13, 2021
Merged

Functions#127
tarasyyyk merged 16 commits into
javascript-tutorial:function-basicsfrom
hypeofpipe:first-steps/function-basics

Conversation

@hypeofpipe

@hypeofpipe hypeofpipe commented Nov 6, 2020

Copy link
Copy Markdown
Contributor

Привіт всім

Вибачаюсь за таку затримку, мої ГітХаб сповіщення були в відділі "спам", ха-ха, дякую Гугл.

Буду старатись переводити далі.

@javascript-translate-bot javascript-translate-bot requested a review from a team November 6, 2020 23:39
@javascript-translate-bot

javascript-translate-bot commented Nov 6, 2020

Copy link
Copy Markdown
Contributor

Error: the article has another translator @hypeofpipe) _[started translation](#1 (comment) in the Progress Issue #1.

@CLAassistant

CLAassistant commented Nov 6, 2020 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ tarasyyyk
❌ hypeofpipe
You have signed the CLA already but the status is still pending? Let us recheck it.

@tarasyyyk

tarasyyyk commented Nov 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Мені сподобався переклад коду та коментарів! Чудово!

@tarasyyyk tarasyyyk mentioned this pull request Nov 7, 2020
Open
tarasyyyk
tarasyyyk requested changes Nov 7, 2020
View reviewed changes
1 hidden conversation Load more…
@javascript-translate-bot

javascript-translate-bot commented Nov 7, 2020

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@tarasyyyk @UkrainianCitizen
Update 1-js/02-first-steps/15-function-basics/article.md …
55203a9 
Co-authored-by: UkrainianCitizen <31314423+UkrainianCitizen@users.noreply.github.com>
@tarasyyyk

tarasyyyk commented Feb 22, 2021

Copy link
Copy Markdown
Collaborator

Привіт, @hypeofpipe !
Є прогрес з перекладом?

tarasyyyk and others added 11 commits July 13, 2021 21:54
@tarasyyyk
Update 1-js/02-first-steps/15-function-basics/article.md
8a08422
@tarasyyyk
Update 1-js/02-first-steps/15-function-basics/article.md
d1b38cb
@tarasyyyk
Update 1-js/02-first-steps/15-function-basics/article.md
9347c84
@tarasyyyk
Update 1-js/02-first-steps/15-function-basics/article.md
99a4606
@tarasyyyk
Update 1-js/02-first-steps/15-function-basics/article.md
7360f68
@tarasyyyk @UkrainianCitizen
Update 1-js/02-first-steps/15-function-basics/article.md …
81913d5 
Co-authored-by: UkrainianCitizen <31314423+UkrainianCitizen@users.noreply.github.com>
@tarasyyyk
Update 1-js/02-first-steps/15-function-basics/article.md
9476b85
@tarasyyyk
Update 1-js/02-first-steps/15-function-basics/article.md
b68b89a
@tarasyyyk
Update 1-js/02-first-steps/15-function-basics/article.md
e55c3c9
@tarasyyyk @UkrainianCitizen
Update 1-js/02-first-steps/15-function-basics/article.md …
6c99a89 
Co-authored-by: UkrainianCitizen <31314423+UkrainianCitizen@users.noreply.github.com>
@tarasyyyk @UkrainianCitizen
Update 1-js/02-first-steps/15-function-basics/article.md …
2ac2bc3 
Co-authored-by: UkrainianCitizen <31314423+UkrainianCitizen@users.noreply.github.com>
@tarasyyyk tarasyyyk changed the base branch from master to function-basics July 13, 2021 19:22
tarasyyyk and others added 2 commits July 13, 2021 22:23
@tarasyyyk
Update 1-js/02-first-steps/15-function-basics/article.md
c4e6355
@tarasyyyk @UkrainianCitizen
Update 1-js/02-first-steps/15-function-basics/article.md …
8c3f1ae 
Co-authored-by: UkrainianCitizen <31314423+UkrainianCitizen@users.noreply.github.com>
@tarasyyyk tarasyyyk marked this pull request as ready for review July 13, 2021 19:48
@tarasyyyk tarasyyyk merged commit 2657e40 into javascript-tutorial:function-basics Jul 13, 2021
@tarasyyyk tarasyyyk mentioned this pull request Jul 13, 2021
Merged
@tarasyyyk

tarasyyyk commented Jul 13, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Виправив деякі конфлікти з гілкою master і злив даний PR в гілку function-basics (яка буде видала після закінчення перекладу). Продовжу переклад в #144.

Дякую, @hypeofpipe за переклад!

@tarasyyyk

tarasyyyk commented Jul 13, 2021

Copy link
Copy Markdown
Collaborator

@all-contributors add @hypeofpipe for translation.

@allcontributors allcontributors Bot mentioned this pull request Jul 13, 2021
Merged
@allcontributors

allcontributors Bot commented Jul 13, 2021

Copy link
Copy Markdown
Contributor

@tarasyyyk

I've put up a pull request to add @hypeofpipe! 🎉

tarasyyyk added a commit that referenced this pull request Aug 12, 2021
@tarasyyyk @hypeofpipe
@UkrainianCitizen @dolgachio
Functions (#144) …
f21f302 
* Functions (#127)

* First part of article.md

* Translate 'Alternative default parameters'

* Fix lines

* Translate 'Returning value'

* Translate 'Naming a function'

* Translate 'Functions == Comments'

* Translate 'Summary'

* Translate tasks

* Small correction

Co-authored-by: Volodymyr V <14982064+hypeofpipe@users.noreply.github.com>
Co-authored-by: UkrainianCitizen <31314423+UkrainianCitizen@users.noreply.github.com>
Co-authored-by: Stanislav <s.dolgachov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarasyyyk tarasyyyk

+1 more reviewer

@UkrainianCitizen UkrainianCitizen UkrainianCitizen left review comments

Assignees

No one assigned

Labels

changes requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hypeofpipe @javascript-translate-bot @CLAassistant @tarasyyyk @UkrainianCitizen