◐ Shell
reader mode source ↗
Skip to content

Map and Set translation#148

Merged
tarasyyyk merged 13 commits into
javascript-tutorial:masterfrom
Regnised:master
Jul 27, 2021
Merged

Map and Set translation#148
tarasyyyk merged 13 commits into
javascript-tutorial:masterfrom
Regnised:master

Conversation

@Regnised

@Regnised Regnised commented Jul 22, 2021

Copy link
Copy Markdown
Contributor

Мова програмування JavaScript -> Data types -> Map i Set
My first translation!

@CLAassistant

CLAassistant commented Jul 22, 2021 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ Regnised
✅ tarasyyyk
❌ Vasyl Onopriienko

Vasyl Onopriienko seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@didostap

didostap commented Jul 22, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Дякую за чудовий переклад!

Помітив декілька граматичних помилок. Прожени, будь ласка, текст через цей сервіс, щоб їх усіх одразу виявити.

Також усі одинарні дефіси в тексті "-" слід зробити подвійними "--".

Vasyl Onopriienko and others added 2 commits July 23, 2021 10:45
@Regnised

Regnised commented Jul 23, 2021

Copy link
Copy Markdown
Contributor Author

Сподіваюсь переклад став кращим. Дякую за лінку на корисний в перекладі ресурс

@tarasyyyk tarasyyyk mentioned this pull request Jul 23, 2021
Open
tarasyyyk
tarasyyyk requested changes Jul 25, 2021
View reviewed changes

@tarasyyyk tarasyyyk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Дякую за переклад!
Декілька невеличких виправлень, і я заллю в основну гілку.

2 hidden conversations Load more…
@javascript-translate-bot

javascript-translate-bot commented Jul 25, 2021

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Regnised and others added 9 commits July 26, 2021 00:44
@Regnised @tarasyyyk
Update 1-js/05-data-types/07-map-set/article.md …
4c8d232 
Co-authored-by: Taras <oster.ok@gmail.com>
@Regnised @tarasyyyk
Update 1-js/05-data-types/07-map-set/article.md …
915ffdb 
Co-authored-by: Taras <oster.ok@gmail.com>
@Regnised @tarasyyyk
Update 1-js/05-data-types/07-map-set/article.md …
5585083 
Co-authored-by: Taras <oster.ok@gmail.com>
@Regnised @tarasyyyk
Update 1-js/05-data-types/07-map-set/article.md …
44a0613 
Co-authored-by: Taras <oster.ok@gmail.com>
@Regnised @tarasyyyk
Update 1-js/05-data-types/07-map-set/article.md …
7b2db38 
Co-authored-by: Taras <oster.ok@gmail.com>
@Regnised @tarasyyyk
Update 1-js/05-data-types/07-map-set/article.md …
a03cc54 
Co-authored-by: Taras <oster.ok@gmail.com>
@Regnised @tarasyyyk
Update 1-js/05-data-types/07-map-set/article.md …
ee5e346 
Co-authored-by: Taras <oster.ok@gmail.com>
@Regnised
Map and Set: spaces and other fixes
9d95f57
@Regnised
Merge branch 'master' of github.com:Regnised/uk.javascript.info
aa21873
@Regnised

Regnised commented Jul 26, 2021

Copy link
Copy Markdown
Contributor Author

/done

@tarasyyyk tarasyyyk merged commit 5667773 into javascript-tutorial:master Jul 27, 2021
@tarasyyyk

tarasyyyk commented Jul 27, 2021

Copy link
Copy Markdown
Collaborator

@all-contributors add @Regnised for translation

@allcontributors allcontributors Bot mentioned this pull request Jul 27, 2021
Merged
@allcontributors

allcontributors Bot commented Jul 27, 2021

Copy link
Copy Markdown
Contributor

@tarasyyyk

I've put up a pull request to add @Regnised! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarasyyyk tarasyyyk tarasyyyk approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Regnised @CLAassistant @didostap @javascript-translate-bot @tarasyyyk