◐ Shell
reader mode source ↗
Skip to content

Strings#230

Merged
tarasyyyk merged 9 commits into
javascript-tutorial:masterfrom
gingano:translation/strings
Dec 18, 2021
Merged

Strings#230
tarasyyyk merged 9 commits into
javascript-tutorial:masterfrom
gingano:translation/strings

Conversation

@gingano

@gingano gingano commented Dec 9, 2021

Copy link
Copy Markdown
Contributor

Strings

@javascript-translate-bot

javascript-translate-bot commented Dec 9, 2021

Copy link
Copy Markdown
Contributor

Error: the article has another translator @gingano) [translation requested](#1 (comment) in the Progress Issue #1.

@CLAassistant

CLAassistant commented Dec 9, 2021 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@gingano

gingano commented Dec 9, 2021

Copy link
Copy Markdown
Contributor Author

Error: the article has another translator @gingano) [translation requested](#1 (comment) in the Progress Issue #1.

@tarasyyyk it's ok ?

tarasyyyk
tarasyyyk requested changes Dec 12, 2021
View reviewed changes

@tarasyyyk tarasyyyk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Дуже об’ємний переклад! Дякую за старання!
Я додав декілька правок

2 hidden conversations Load more…
@javascript-translate-bot

javascript-translate-bot commented Dec 12, 2021

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@gingano

gingano commented Dec 15, 2021

Copy link
Copy Markdown
Contributor Author

/done

@gingano gingano requested a review from tarasyyyk December 15, 2021 08:41
tarasyyyk
tarasyyyk approved these changes Dec 17, 2021
View reviewed changes

@tarasyyyk tarasyyyk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Нарешті переклад цієї величезної статті завершено!
Велике Спасибі!

@tarasyyyk

tarasyyyk commented Dec 17, 2021

Copy link
Copy Markdown
Collaborator

@gingano, залишилось підписати CLA.

@gingano gingano requested a review from tarasyyyk December 18, 2021 12:49
@gingano

gingano commented Dec 18, 2021

Copy link
Copy Markdown
Contributor Author

@tarasyyyk підписав, можеш мерджити

@tarasyyyk

tarasyyyk commented Dec 18, 2021

Copy link
Copy Markdown
Collaborator

@all-contributors add @gingano for translation.

@allcontributors allcontributors Bot mentioned this pull request Dec 18, 2021
Merged
@allcontributors

allcontributors Bot commented Dec 18, 2021

Copy link
Copy Markdown
Contributor

@tarasyyyk

I've put up a pull request to add @gingano! 🎉

@tarasyyyk tarasyyyk merged commit a92f1be into javascript-tutorial:master Dec 18, 2021
@javascript-translate-bot

javascript-translate-bot commented Dec 18, 2021

Copy link
Copy Markdown
Contributor

Error: the article has another translator @gingano) [translation requested](#1 (comment), not @gingano in the Progress Issue #1. Please update the progress issue or ask maintainers to do so.

@tarasyyyk tarasyyyk mentioned this pull request Dec 18, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarasyyyk tarasyyyk tarasyyyk approved these changes

Assignees

No one assigned

Labels

needs +1 ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gingano @javascript-translate-bot @CLAassistant @tarasyyyk @oleksii-kovalenko-gingano