◐ Shell
reader mode source ↗
Skip to content

BigInt#136

Open
fixiabis wants to merge 2 commits into
javascript-tutorial:masterfrom
fixiabis:BigInt
Open

BigInt#136
fixiabis wants to merge 2 commits into
javascript-tutorial:masterfrom
fixiabis:BigInt

Conversation

@fixiabis

@fixiabis fixiabis commented Apr 12, 2021

Copy link
Copy Markdown
Contributor

Target chapter

1-js/99-js-misc/05-bigint

Modified files

File name Change（reason）
article.md 翻譯繁體中文

@javascript-translate-bot javascript-translate-bot requested a review from a team April 12, 2021 10:24
@javascript-translate-bot javascript-translate-bot mentioned this pull request Apr 12, 2021
Open
@CLAassistant

CLAassistant commented Apr 12, 2021 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

lenchen1112
lenchen1112 approved these changes Apr 12, 2021
View reviewed changes

@lenchen1112 lenchen1112 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks for your efforts :)

lenchen1112
lenchen1112 requested changes Apr 12, 2021
View reviewed changes

@lenchen1112 lenchen1112 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Some suggestions.

@javascript-translate-bot

javascript-translate-bot commented Apr 12, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@fixiabis

fixiabis commented Apr 14, 2021

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team April 14, 2021 10:27
lenchen1112
lenchen1112 approved these changes Apr 17, 2021
View reviewed changes

@lenchen1112 lenchen1112 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM.
@javascript-tutorial/translate-zh-hant please give one more review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lenchen1112 lenchen1112 lenchen1112 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

needs +1 review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fixiabis @CLAassistant @javascript-translate-bot @lenchen1112