◐ Shell
reader mode source ↗
Skip to content

Private and protected properties and methods#451

Merged
lycheeEng merged 3 commits into
javascript-tutorial:masterfrom
ish-kafel:master
Aug 16, 2019
Merged

Private and protected properties and methods#451
lycheeEng merged 3 commits into
javascript-tutorial:masterfrom
ish-kafel:master

Conversation

@ish-kafel

@ish-kafel ish-kafel commented Aug 14, 2019 •
edited by lycheeEng
Loading

Copy link
Copy Markdown
Contributor

目标章节：1-js/09-classes/04-private-protected-properties-methods

当前上游最新 commit：7fd3eb1

所做更改如下：

文件名 参考上游 commit 更改（理由）
article.md 6d1fa5d 翻译为中文

@ish-kafel
Translate into Chinese …
eb0e318 
Translate into Chinese
@javascript-translate-bot javascript-translate-bot requested a review from a team August 14, 2019 08:27
@CLAassistant

CLAassistant commented Aug 14, 2019 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@iliakan iliakan mentioned this pull request Aug 14, 2019
Closed
@lycheeEng

lycheeEng commented Aug 14, 2019

Copy link
Copy Markdown
Collaborator

校对认领

@lycheeEng

lycheeEng commented Aug 14, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

看了一下英文版，原作者对这部分内容有改动，要不你先与英文版同步修改一下？
英文版：https://github.com/javascript-tutorial/en.javascript.info/blob/master/1-js/09-classes/04-private-protected-properties-methods/article.md

@ish-kafel
Update article.md …
6353ee1 
同步英文版
@ish-kafel

ish-kafel commented Aug 15, 2019

Copy link
Copy Markdown
Contributor Author

已和英文版同步

lycheeEng
lycheeEng reviewed Aug 16, 2019
View reviewed changes

@lycheeEng lycheeEng left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

校对完成，感谢翻译

13 hidden conversations Load more…
@ish-kafel

ish-kafel commented Aug 16, 2019

Copy link
Copy Markdown
Contributor Author

感谢校正，已修正翻译

@lycheeEng

lycheeEng commented Aug 16, 2019

Copy link
Copy Markdown
Collaborator

再次感谢~

@lycheeEng lycheeEng merged commit a19b51a into javascript-tutorial:master Aug 16, 2019
@javascript-translate-bot

javascript-translate-bot commented Aug 16, 2019

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #324 🎉 🎉 🎉

@lycheeEng lycheeEng added DONE and removed needs +1 labels Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lycheeEng lycheeEng

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

DONE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ish-kafel @CLAassistant @lycheeEng @javascript-translate-bot