◐ Shell
reader mode source ↗
Skip to content

ArrayBuffer, binary arrays#529

Merged
leviding merged 15 commits into
masterfrom
unknown repository
Dec 5, 2019
Merged

ArrayBuffer, binary arrays#529
leviding merged 15 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Nov 20, 2019 •
edited by ghost
Loading

Copy link
Copy Markdown

目标章节：4-binary/01-arraybuffer-binary-arrays

当前上游最新 commit：54984506

所做更改如下：

文件名 参考上游 commit 更改（理由）
article.md c5ce557 新增翻译文件
o1-concat/task.md 6fb4aab 新增翻译文件
_js.view/solution.js 6fb4aab 新增翻译文件
_js.view/source.js 6fb4aab 新增翻译文件

@javascript-translate-bot javascript-translate-bot requested a review from a team November 20, 2019 15:01
@iliakan iliakan mentioned this pull request Nov 20, 2019
Closed
@ghost ghost changed the title ArrayBuffer, binary arrays Nov 29, 2019
@ghost ghost changed the title [WIP] ArrayBuffer, binary arrays Nov 29, 2019
@KerbalHao

KerbalHao commented Nov 30, 2019

Copy link
Copy Markdown
Collaborator

还请麻烦您修改一下 PR 内容，写上修改的文件和参考的上游 commit 等

@javascript-translate-bot

javascript-translate-bot commented Nov 30, 2019

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@ghost

ghost commented Nov 30, 2019

Copy link
Copy Markdown
Author

还请麻烦您修改一下 PR 内容，写上修改的文件和参考的上游 commit 等

已修改，谢谢~

/done

KerbalHao
KerbalHao reviewed Dec 2, 2019
View reviewed changes

@KerbalHao KerbalHao left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

感谢翻译，校对完毕

@ghost

ghost commented Dec 2, 2019

Copy link
Copy Markdown
Author

感谢校对，已修改~

/done

14 hidden items Load more…
leviding
leviding requested changes Dec 4, 2019
View reviewed changes

@leviding leviding left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

存在几点问题，麻烦译者 @bemself 注意一下，并进行修改：

  1. 格式细节问题需要仔细
  2. 翻译成中文的，那就不要用英文的引号来扩中文汉字，符号也要相应改为中文全角
  3. 空格等细节格式问题
  4. 168 行的 2<sup>8</sup> 是 28，也就是 2 的八次方，不是取余吧？

@KerbalHao 麻烦校对者也注意，在审核翻译的同时，也要审核格式问题。

27 hidden conversations Load more…
@javascript-translate-bot

javascript-translate-bot commented Dec 4, 2019

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@leviding

leviding commented Dec 4, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

麻烦两位 @bemself @KerbalHao 都看下校对意见，现根据校对意见修改一遍，修改的同时需要检查是否还有类似问题，一并修改，辛苦了。

bemself and others added 7 commits December 4, 2019 19:35
@leviding
arraybuffer: resolve review comment …
95d6677 
resolve review comment

Co-Authored-By: LeviDing <imdingxuewen@gmail.com>
@leviding
arraybuffer: resolve review comment …
73e1cba 
Co-Authored-By: LeviDing <imdingxuewen@gmail.com>
@leviding
arraybuffer: resolve review comment …
fa9d61e 
Co-Authored-By: LeviDing <imdingxuewen@gmail.com>
@leviding
arraybuffer: resolve review comment …
d823f7c 
Co-Authored-By: LeviDing <imdingxuewen@gmail.com>
@leviding
arraybuffer: resolve review comment …
82ec646 
Co-Authored-By: LeviDing <imdingxuewen@gmail.com>
arraybuffer: update against review comments
192760a
arraybuffer: update against review comment
e2c0214
@ghost

ghost commented Dec 4, 2019

Copy link
Copy Markdown
Author

@leviding 感谢校对，已修改~

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team December 4, 2019 14:56
@ghost

ghost commented Dec 5, 2019

Copy link
Copy Markdown
Author

@KerbalHao 感谢校对，已修改。

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team December 5, 2019 12:26
@leviding leviding merged commit 34f4904 into javascript-tutorial:master Dec 5, 2019
@javascript-translate-bot

javascript-translate-bot commented Dec 5, 2019

Copy link
Copy Markdown

Error: the article already translated in the Progress Issue #324 ⁉️

@leviding leviding added DONE and removed needs +1 labels Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

DONE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KerbalHao @javascript-translate-bot @leviding