{{ message }}
fix: combined cleanup — WETH, fullFeature guards, shebangs, ripple CLI#176
Merged
pastaghost merged 5 commits intoMar 12, 2026
Merged
fix: combined cleanup — WETH, fullFeature guards, shebangs, ripple CLI#176pastaghost merged 5 commits into
pastaghost merged 5 commits into
Conversation
Contributor
Sorry, something went wrong.
BitHighlander
force-pushed
the
fix/combined-cleanup
branch
from
0b9b573 to
c5cd85a
Compare
March 6, 2026 01:14
pastaghost
approved these changes
Mar 12, 2026
pastaghost
left a comment
pastaghost
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
WETH exists in ethereum-lists/src/tokens/eth/ which generates ethereum_tokens.def. Adding it to uniswap_tokens.json created a duplicate ticker, causing tokenByTicker() to return false. Also removes the unittest.skip since WETH is available via ethereum-lists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Summary
Combines 4 open PRs into a single clean changeset:
zxappliquid.cuniswap approve handlerrequires_fullFeature()totest_sign_eth_btc_swapandtest_sign_eth_add_liquidityso they skip on BTC-only firmware#!/bin/env python3→#!/usr/bin/env python3in 2 filesripple_get_addresscommand tokeepkeyctlSupersedes
PRs #173, #175, #170, #165 — close those after merging this one.
Test plan
test_sign_uni_approve_liquidity_ETHpasses/bin/envkeepkeyctl ripple_get_addressavailable