◐ Shell
reader mode source ↗
Skip to content

Hold strong reference to all buffers passed to LmdbJava (fixes #207)#214

Merged
bp-alex merged 1 commit into
lmdbjava:masterfrom
2018ik:fixcorruptionbug
Apr 24, 2023
Merged

Hold strong reference to all buffers passed to LmdbJava (fixes #207)#214
bp-alex merged 1 commit into
lmdbjava:masterfrom
2018ik:fixcorruptionbug

Conversation

@2018ik

@2018ik 2018ik commented Mar 23, 2023

Copy link
Copy Markdown
Contributor

See repro steps: #207 (comment)

With this change, I don't see the issue anymore. Doesn't rely on reachabilityFence since that is JDK 9+

@2018ik 2018ik force-pushed the fixcorruptionbug branch from d01270b to 0c636f1 Compare April 21, 2023 22:39
@bp-alex bp-alex merged commit c5e02f7 into lmdbjava:master Apr 24, 2023
@bp-alex

bp-alex commented Apr 24, 2023

Copy link
Copy Markdown
Member

Thanks @2018ik, I have merged this.

I made some adjustments and commented in related commit cbdaee6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants