{{ message }}
gh-249 Remove MDB_UNSIGNEDKEY, let CursorIterable call mdb_cmp#250
Closed
at055612 wants to merge 25 commits into
Closed
gh-249 Remove MDB_UNSIGNEDKEY, let CursorIterable call mdb_cmp#250at055612 wants to merge 25 commits into
at055612 wants to merge 25 commits into
Conversation
Collaborator
Sorry, something went wrong.
There are now essentially three ways of configuring comparators when creating a Dbi. **null comparator** LMDB will use its own comparator & CursorIterable will call down to mdb_cmp for comparisons between the current cursor key and the range start/stop key. **provided comparator** LMDB will use its own comparator & CursorIterable will use the provided comparator for comparisons between the current cursor key and the range start/stop key. **provided comparator with nativeCb==true** LMDB will call back to java for all comparator duties. CursorIterable will use the same provided comparator for comparisons between the current cursor key and the range start/stop key. The methods `getSignedComparator()` and `getUnsignedComparator()` have been made public so users of this library can access them.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #250 +/- ##
============================================
- Coverage 89.06% 85.06% -4.01%
- Complexity 413 507 +94
============================================
Files 32 41 +9
Lines 1482 1962 +480
Branches 125 180 +55
============================================
+ Hits 1320 1669 +349
- Misses 92 177 +85
- Partials 70 116 +46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
1 hidden conversation
Load more…
bp-alex
force-pushed
the
master
branch
2 times, most recently
from
5e03aec to
e598e21
Compare
October 25, 2025 04:27
Refactor DbiBuilder and Dbi ctor to use DbiFlagSet.
Replace Env#copy(File, CopyFlags...) with copy(File, CopyFlagSet). As there is only one flag this should not be a breaking change. Deprecate Env#txn(Txn, TxnFlags...) as there is now Env#txn(Txn) Env#txn(Txn, TxnFlags) Env#txn(Txn, TxnFlagSet)
Also improve javadoc and refactor some tests to use DbiBuilder. Some tests are failing.
Collaborator
Author
|
Closing this as the changes have been moved to PR #276 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Fixes #249
There are now essentially three ways of configuring comparators when creating a Dbi.
null comparator
LMDB will use its own comparator & CursorIterable will call down to mdb_cmp for comparisons between the current cursor key and the range start/stop key.
provided comparator
LMDB will use its own comparator & CursorIterable will use the provided comparator for comparisons between the current cursor key and the range start/stop key.
provided comparator with nativeCb==true
LMDB will call back to java for all comparator duties. CursorIterable will use the same provided comparator for comparisons between the current cursor key and the range start/stop key.
The methods
getSignedComparator()andgetUnsignedComparator()have been made public so users of this library can access them.