◐ Shell
reader mode source ↗
Skip to content

[WIP] Add add support for Timestamp type#431

Closed
frsyuki wants to merge 1 commit into
developfrom
msgpack-21-timestamp
Closed

[WIP] Add add support for Timestamp type#431
frsyuki wants to merge 1 commit into
developfrom
msgpack-21-timestamp

Conversation

@frsyuki

@frsyuki frsyuki commented Aug 10, 2017

Copy link
Copy Markdown
Member

Implementation is still working in progress.
Here is the spec of the new timestamp type: msgpack/msgpack#209

@xerial

xerial commented Oct 21, 2017

Copy link
Copy Markdown
Member

TODO:

  • Add timestamp MessageFormat types?
  • Add timestamp Value type

@mattbishop

mattbishop commented Nov 27, 2017

Copy link
Copy Markdown

How is the timestamp feature coming along? I know the msgpack-js project is getting close to a release: kawanet/msgpack-lite#76

@xerial

xerial commented Nov 29, 2017

Copy link
Copy Markdown
Member

@mattbishop We haven't decided how to add above two things; whether to add MessageFormat
type and ValueType for describing timestamp.

In the msgpack spec, timestamp is just one of the Extention types. We think adding these two additional types will be convenient for timestamp users. However, adding these types is a big change to the API (since most of the users is using switch case statement for checking data type, so rewriting will be necessary by adding case Timestamp: ...). We need to be careful so as not to break user programs that started to use timestamp types in future versions.

@gustf

gustf commented Apr 18, 2020

Copy link
Copy Markdown

Hi there, any progress on this feature?

@xerial xerial mentioned this pull request May 11, 2021
8 tasks
@xerial

xerial commented May 12, 2021

Copy link
Copy Markdown
Member

Continuing the work at #565

@xerial

xerial commented May 12, 2021

Copy link
Copy Markdown
Member

Closing this PR in favor of #565

@xerial xerial closed this May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants