{{ message }}
expose method to create parser from direct memory#435
Open
arnaudroger wants to merge 1 commit into
Open
Conversation
Sorry, something went wrong.
Member
|
@komamitsu Could you review this change? This seems a good improvement. |
Sorry, something went wrong.
komamitsu
requested changes
Oct 21, 2017
komamitsu
left a comment
komamitsu
left a comment
Member
There was a problem hiding this comment.
@arnaudroger Thanks for the contribution! It seems a cool feature.
But I have some questions. Can I ask you to take a look at them?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Useful to parse message coming in from netty for example without creating a lot of garbage.
Also expose the method to create a parser from a sub array.