{{ message }}
fix: check return code in unpack_callback_int64#665
Merged
methane merged 4 commits intoApr 21, 2026
Merged
Conversation
Contributor
Sorry, something went wrong.
KowalskiThomas
force-pushed
the
kowalski/fix-check-return-code-in-unpack_callback_int64
branch
from
4b0097e to
5142b3d
Compare
April 20, 2026 18:07
methane
approved these changes
Apr 21, 2026
methane
pushed a commit
that referenced
this pull request
Apr 21, 2026
Similar to #665, just a return value check to propagate the error in case one happens (instead of silently ignoring it). Note that as opposed to the previous lines, we don't need to `PyErr_SetString` since `unpack_callback_uint32` calls `PyLong_FromSize_t` which itself should set whatever Python error is relevant; we just need to make it clear to the caller that an error occurred.
methane
reviewed
Apr 21, 2026
Refactor unpack_callback_int64 to simplify PyObject creation.
methane
approved these changes
Apr 21, 2026
Hide details
View details
methane
merged commit
methane
merged commit 95c8be5
into
msgpack:main
Apr 21, 2026
26 checks passed
KowalskiThomas
deleted the
kowalski/fix-check-return-code-in-unpack_callback_int64
branch
April 29, 2026 07:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
+1 more reviewer
3 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
This simply adds a null pointer check after calling
PyLong_FromLongLong/PyLong_FromLonglike other similar functions do it (example here).