{{ message }}
fix: properly handle return codes in pack_timestamp#672
Merged
methane merged 1 commit intoMay 23, 2026
Merged
Conversation
Contributor
Sorry, something went wrong.
KowalskiThomas
commented
May 11, 2026
methane
approved these changes
May 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures msgpack_pack_timestamp() correctly propagates failures from the underlying packing helpers, so callers can observe and handle allocation/write errors instead of silently succeeding.
Changes:
- Capture and check the return value from
msgpack_pack_ext()in all timestamp encoding branches. - Propagate the return value from
msgpack_pack_raw_body()(instead of always returning0). - Normalize indentation in the
timestamp96branch to match the surrounding style.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Hide details
View details
methane
merged commit
methane
merged commit 378edc6
into
msgpack:main
May 23, 2026
26 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot code review Copilot Copilot left review comments
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
What is this PR?
This PR makes it so that return codes of helpers called in
msgpack_pack_extare properly checked and surfaced if they're indicative of a failure.Note the "big" diff at the end of the function is an indentation change on top of the actual change -- the code used to be indented with three spaces instead of four. I changed that (should be clear looking at the diff without whitespace changes).