◐ Shell
reader mode source ↗
Skip to content

test: simplify loadDHParam in TLS test#18103

Closed
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:simplify-loaddhparam
Closed

test: simplify loadDHParam in TLS test#18103
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:simplify-loaddhparam

Conversation

@tniessen

Copy link
Copy Markdown
Member

Neither of these tests seems to use the error value.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 11, 2018
@tniessen

Copy link
Copy Markdown
Member Author

@tniessen

Copy link
Copy Markdown
Member Author

Landed in eb68a06.

@tniessen tniessen closed this Jan 17, 2018
tniessen added a commit that referenced this pull request Jan 17, 2018
PR-URL: #18103
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
PR-URL: #18103
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
PR-URL: #18103
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
PR-URL: #18103
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants