{{ message }}
http2: fixes error handling#19232
Closed
mcollina wants to merge 1 commit into
Closed
Conversation
Member
Sorry, something went wrong.
nodejs-github-bot
added
dont-land-on-v4.x
http2
Issues or PRs related to the http2 subsystem.
labels
Mar 8, 2018
mcollina
requested review from
addaleax,
apapirovski and
jasnell
and removed request for
jasnell
March 8, 2018 15:42
Member
Author
|
cc @nodejs/http2 |
Sorry, something went wrong.
Member
Author
Sorry, something went wrong.
There should be no default error handling when using Http2Stream. All errors will end up in `'streamError'` on the server anyway, but they are emitted on `'stream'` as well, otherwise some error conditions are impossible to debug. See: nodejs#14991
jasnell
approved these changes
Mar 8, 2018
mcollina
force-pushed
the
fixed-error-handling
branch
from
bf33cfc to
80f9390
Compare
March 8, 2018 17:00
Member
Author
Sorry, something went wrong.
trivikr
approved these changes
Mar 8, 2018
mcollina
added a commit
that referenced
this pull request
Mar 12, 2018
There should be no default error handling when using Http2Stream. All errors will end up in `'streamError'` on the server anyway, but they are emitted on `'stream'` as well, otherwise some error conditions are impossible to debug. See: #14991 PR-URL: #19232 Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
|
This is causing a linter error on v9.x Should this be backported to |
Sorry, something went wrong.
Member
Author
|
on its way. |
Sorry, something went wrong.
mcollina
added a commit
to mcollina/node
that referenced
this pull request
Mar 20, 2018
There should be no default error handling when using Http2Stream. All errors will end up in `'streamError'` on the server anyway, but they are emitted on `'stream'` as well, otherwise some error conditions are impossible to debug. See: nodejs#14991 PR-URL: nodejs#19232 Reviewed-By: James M Snell <jasnell@gmail.com>
4 tasks
mcollina
added a commit
to mcollina/node
that referenced
this pull request
Mar 21, 2018
There should be no default error handling when using Http2Stream. All errors will end up in `'streamError'` on the server anyway, but they are emitted on `'stream'` as well, otherwise some error conditions are impossible to debug. See: nodejs#14991 PR-URL: nodejs#19232 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2018
There should be no default error handling when using Http2Stream. All errors will end up in `'streamError'` on the server anyway, but they are emitted on `'stream'` as well, otherwise some error conditions are impossible to debug. See: #14991 Backport-PR-URL: #19478 PR-URL: #19232 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
There should be no default error handling when using Http2Stream. All errors will end up in `'streamError'` on the server anyway, but they are emitted on `'stream'` as well, otherwise some error conditions are impossible to debug. See: nodejs#14991 PR-URL: nodejs#19232 Reviewed-By: James M Snell <jasnell@gmail.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
There should be no default error handling when using Http2Stream.
All errors will end up in
'streamError'on the server anyway,but they are emitted on
'stream'as well, otherwise some errorconditions are impossible to debug.
See: #14991
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes