◐ Shell
reader mode source ↗
Skip to content

test: don't remove empty.txt on win32#2

Merged
rvagg merged 1 commit into
v0.12from
test-net-pipe-connect-errors-socket-path-win-fix-2
Nov 29, 2014
Merged

test: don't remove empty.txt on win32#2
rvagg merged 1 commit into
v0.12from
test-net-pipe-connect-errors-socket-path-win-fix-2

Conversation

@rvagg

@rvagg rvagg commented Nov 27, 2014

Copy link
Copy Markdown
Member

Take 3: on win32 we use empty.txt in the fixtures directory, otherwise we use a file constructed specifically for this test due to POSIX socket path length limitations, in which case we need to do appropriate cleanup. Cleaning up empty.txt in fixtures causes downstream problems for other tests using it (currently the next test is test-zlib).

@rvagg
test: don't remove empty.txt on win32 …
9006e94 
on win32 we use empty.txt in the fixtures directory, otherwise we
use a file constructed specifically for this test due to POSIX
socket path length limitations, in which case we need to do
appropriate cleanup
@indutny

indutny commented Nov 28, 2014

Copy link
Copy Markdown
Member

LGTM

@bnoordhuis

bnoordhuis commented Nov 28, 2014

Copy link
Copy Markdown
Member

Another LGTM.

@bnoordhuis

bnoordhuis commented Nov 28, 2014

Copy link
Copy Markdown
Member

@rvagg By the way, do you have commit rights? I'd like you to land your patches yourself.

@rvagg

rvagg commented Nov 28, 2014

Copy link
Copy Markdown
Member Author

@bnoordhuis sure, is there anything special I need to know about the normal merge procedure?

@bnoordhuis

bnoordhuis commented Nov 29, 2014

Copy link
Copy Markdown
Member

@rvagg Just the normal commit log as described in CONTRIBUTING.md plus PR-URL and Reviewed-By tags. Basically, what you see when you run git log now.

@rvagg rvagg merged this pull request into v0.12 Nov 29, 2014
@rvagg rvagg deleted the test-net-pipe-connect-errors-socket-path-win-fix-2 branch November 29, 2014 01:00
rvagg added a commit that referenced this pull request Nov 29, 2014
@rvagg
test: don't remove empty.txt on win32 …
013527a 
on win32 we use empty.txt in the fixtures directory, otherwise we
use a file constructed specifically for this test due to POSIX
socket path length limitations, in which case we need to do
appropriate cleanup

Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: #2
@jmar777 jmar777 mentioned this pull request Feb 21, 2015
Closed
@JediMindtrick JediMindtrick mentioned this pull request Apr 4, 2015
Closed
@yjhjstz yjhjstz mentioned this pull request May 14, 2015
Closed
@dashed dashed mentioned this pull request May 31, 2015
Closed
@Fishrock123 Fishrock123 mentioned this pull request Jun 21, 2015
Closed
@snorp snorp mentioned this pull request Aug 7, 2015
Closed
@silverwind silverwind mentioned this pull request Sep 23, 2015
Closed
@jasnell jasnell mentioned this pull request Oct 12, 2015
Closed
@silverwind silverwind mentioned this pull request Oct 14, 2015
Closed
@kvic-z kvic-z mentioned this pull request Oct 27, 2015
Closed
jasnell added a commit that referenced this pull request Nov 2, 2015
@jasnell
2015-10-29, Version 4.2.2 RC2 (LTS) …
dd1f411 
Release Candidate #2
@jasnell jasnell mentioned this pull request Nov 16, 2015
Closed
@chvostek chvostek mentioned this pull request Nov 20, 2015
Closed
@gireeshpunathil gireeshpunathil mentioned this pull request Nov 24, 2015
Closed
@alanpurple alanpurple mentioned this pull request Dec 8, 2015
Closed
@jianpingw jianpingw mentioned this pull request Dec 13, 2015
Closed
135 hidden items Load more…
@HiveTechDev HiveTechDev mentioned this pull request Apr 29, 2022
Closed
@mhdawson mhdawson mentioned this pull request Sep 26, 2022
Closed
@theanarkh theanarkh mentioned this pull request Oct 18, 2022
Closed
juanarbol pushed a commit to juanarbol/node that referenced this pull request Mar 1, 2023
@sepehrst @juanarbol
deps: V8: cherry-pick c875e86df1d7 (nodejs#2) …
795f9d8 
Original commit message:

    [bigint] Convert BigInt property names to decimal

    Hexadecimal/octal/binary BigInt property names should be converted
    to decimal, i.e. the following object literals should all be equivalent:
    var o = {0xF: 1}, p = {0xFn: 1}, q = {15: 1}, r = {15n: 1}.

    Test case by yangwenming@bytedance.com, uploaded at
    https://chromium-review.googlesource.com/c/v8/v8/+/3634937

    Fixed: v8:10600
    Change-Id: Ie1d8a16e95697cd31cbc0784843779c921ce91fa
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3642302
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80490}

Refs: v8/v8@c875e86
PR-URL: nodejs#46501
Refs: v8/v8@c875e86
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@juanarbol juanarbol mentioned this pull request Mar 3, 2023
Merged
@mshopf mshopf mentioned this pull request Jun 15, 2023
Open
@khagankhan khagankhan mentioned this pull request Oct 13, 2023
Closed
@orsett0 orsett0 mentioned this pull request Dec 28, 2023
Open
@bocchi810 bocchi810 mentioned this pull request Jan 4, 2024
Closed
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2024
Closed
@kshaa kshaa mentioned this pull request Mar 1, 2024
Closed
@eugeneo eugeneo mentioned this pull request Apr 15, 2024
Merged
@benjamingr benjamingr mentioned this pull request Jun 28, 2024
Closed
@avivkeller avivkeller mentioned this pull request Jul 6, 2024
Merged
sungpaks added a commit to sungpaks/node that referenced this pull request Jul 29, 2024
@sungpaks
test: fix subtest nodejs#1, nodejs#2 of test-node-run …
0837107 
Subtest nodejs#1, nodejs#2 of test-node-run.js originally matched the error message
"Can't read package.json" on non-existent file. However, the subtests
failed on Ubuntu20.04. we found that attempting to run a non-existent
script like `node --run foo` using the latest version of node results in
an error message like `Can't find “scripts” field in package.json`
(on Ubuntu20.04, regardless of whether package.json is present in the
subpath or not). So we modified the subtest so that if we match either
of the two messages, the test passes.
sungpaks added a commit to sungpaks/node that referenced this pull request Jul 29, 2024
@sungpaks
test: fix subtest nodejs#1, nodejs#2 of test-node-run …
e537e46 
Subtest nodejs#1, nodejs#2 of test-node-run.js originally matched the error message
"Can't read package.json" on non-existent file. However, the subtests
failed on Ubuntu20.04. we found that attempting to run a non-existent
script like `node --run foo` using the latest version of node results in
an error message like `Can't find “scripts” field in package.json`
(on Ubuntu20.04, regardless of whether package.json is present in the
subpath or not). So we modified the subtest so that if we match either
of the two messages, the test passes.
@Qard Qard mentioned this pull request Feb 3, 2025
Closed
@siwenwang0803

siwenwang0803 commented Jun 29, 2025

Copy link
Copy Markdown

🤖 Secure-PR-Guard AI Code Review

Analysis completed at: 2025-06-28 20:39:59 UTC
PR: #2

🟡 Risk Assessment: MEDIUM

  • Total Issues Found: 4
  • Security Issues: 0

🟢 Low Priority Issues

  • Line 45 (length): Line 45 exceeds 120 characters.
  • Line 49 (length): Line 49 exceeds 120 characters.
  • Line 51 (length): Line 51 exceeds 120 characters.
  • Line 53 (length): Line 53 exceeds 120 characters.

🔗 Powered by Secure-PR-Guard | 🛡️ OWASP LLM Top 10 Compliant

This is an automated review. Please verify critical security findings manually.

@siwenwang0803

siwenwang0803 commented Jun 29, 2025

Copy link
Copy Markdown

🤖 Secure-PR-Guard AI Code Review

Analysis completed at: 2025-06-28 21:19:12 UTC
PR: #2

🟡 Risk Assessment: MEDIUM

  • Total Issues Found: 2
  • Security Issues: 0

🟢 Low Priority Issues

  • Line 20 (length): Line exceeds 120 characters, consider breaking it into multiple lines for better readability.
  • Line 17 (style): Use of inconsistent indentation; consider using 2 spaces for proper code alignment instead of mixing styles.

🔗 Powered by Secure-PR-Guard | 🛡️ OWASP LLM Top 10 Compliant

This is an automated review. Please verify critical security findings manually.

@ronking-zhu ronking-zhu mentioned this pull request Oct 13, 2025
Closed
@Mohit-Raj-Saxena Mohit-Raj-Saxena mentioned this pull request Oct 16, 2025
Closed
@sadan4 sadan4 mentioned this pull request Nov 5, 2025
Closed
@jackzhp jackzhp mentioned this pull request Nov 5, 2025
Open
nabsul added a commit to nabsul/node that referenced this pull request Nov 18, 2025
@nabsul
Try nodejs#2
42d0f18
Copilot AI referenced this pull request in Multi-V-VM/node-wasix32 Mar 20, 2026
@tonidy
Merge pull request #2 from tonidy/claude/fix-v8-timedeltanamespace-01… …
9f9e4e2 
…YErq3jenbmvHPj2ccYEnYH
ndossche added a commit to ndossche/node that referenced this pull request May 21, 2026
@ndossche
src: fix edge case when deflateInit2() fails with Z_VERSION_ERROR …
a886356 
This function call can fail with `Z_VERSION_ERROR` if the compiled
library vs loaded library mismatched in version number or in
stream structure size.
In those cases, zlib doesn't initialize the `strm_.msg` field to
null. Therefore, when a `CompressionError` object is created via
`ErrorForMessage()`, it can read a stale or uninitialized `strm_.msg`
pointer that will cause a crash.

Example ASAN report:
```
AddressSanitizer: SEGV on unknown address
    #0 __strlen_avx2
        string/../sysdeps/x86_64/multiarch/strlen-avx2.S:76
    nodejs#1 strlen (/work/node/out/Debug/node+0x1a42ab7)
    nodejs#2 v8::(anonymous namespace)::StringLength(char const*)
        /work/node/out/../deps/v8/src/api/api.cc:7581:16
    nodejs#3 v8::(anonymous namespace)::StringLength(unsigned char const*)
        /work/node/out/../deps/v8/src/api/api.cc:7587:10
    nodejs#4 v8::String::NewFromOneByte(v8::Isolate*,
        unsigned char const*, v8::NewStringType, int)
        /work/node/out/../deps/v8/src/api/api.cc:7677:3
    nodejs#5 node::OneByteString(v8::Isolate*,
        char const*, int, v8::NewStringType)
        /work/node/out/../src/util-inl.h:166:10
    nodejs#6 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::EmitError(node::(anonymous namespace)
        ::CompressionError const&)
        /work/node/out/../src/node_zlib.cc:565:7
    nodejs#7 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::CheckError()
        /work/node/out/../src/node_zlib.cc:519:5
    nodejs#8 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::AfterThreadPoolWork(int)
        /work/node/out/../src/node_zlib.cc:543:10
    nodejs#9 node::ThreadPoolWork::ScheduleWork()
        ::'lambda'(uv_work_s*, int)
        ::operator()(uv_work_s*, int) const
        /work/node/out/../src/threadpoolwork-inl.h:57:15
    nodejs#10 node::ThreadPoolWork::ScheduleWork()
        ::'lambda'(uv_work_s*, int)
        ::__invoke(uv_work_s*, int)
        /work/node/out/../src/threadpoolwork-inl.h:48:7
    nodejs#11 uv__work_done /work/libuv-1.51.0/src/threadpool.c:330:5
    nodejs#12 uv__async_io.part.0
        /work/libuv-1.51.0/src/unix/async.c:208:5
```

Signed-off-by: ndossche <nora.dossche@ugent.be>
ndossche added a commit to ndossche/node that referenced this pull request May 21, 2026
@ndossche
src: fix edge case when deflateInit2() fails with Z_VERSION_ERROR …
c6ea900 
This function call can fail with `Z_VERSION_ERROR` if the compiled
library vs loaded library mismatched in version number or in
stream structure size.
In those cases, zlib doesn't initialize the `strm_.msg` field to
null. Therefore, when a `CompressionError` object is created via
`ErrorForMessage()`, it can read a stale or uninitialized `strm_.msg`
pointer that will cause a crash.

Example ASAN report:
```
AddressSanitizer: SEGV on unknown address
    #0 __strlen_avx2
        string/../sysdeps/x86_64/multiarch/strlen-avx2.S:76
    nodejs#1 strlen (/work/node/out/Debug/node+0x1a42ab7)
    nodejs#2 v8::(anonymous namespace)::StringLength(char const*)
        /work/node/out/../deps/v8/src/api/api.cc:7581:16
    nodejs#3 v8::(anonymous namespace)::StringLength(unsigned char const*)
        /work/node/out/../deps/v8/src/api/api.cc:7587:10
    nodejs#4 v8::String::NewFromOneByte(v8::Isolate*,
        unsigned char const*, v8::NewStringType, int)
        /work/node/out/../deps/v8/src/api/api.cc:7677:3
    nodejs#5 node::OneByteString(v8::Isolate*,
        char const*, int, v8::NewStringType)
        /work/node/out/../src/util-inl.h:166:10
    nodejs#6 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::EmitError(node::(anonymous namespace)
        ::CompressionError const&)
        /work/node/out/../src/node_zlib.cc:565:7
    nodejs#7 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::CheckError()
        /work/node/out/../src/node_zlib.cc:519:5
    nodejs#8 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::AfterThreadPoolWork(int)
        /work/node/out/../src/node_zlib.cc:543:10
    nodejs#9 node::ThreadPoolWork::ScheduleWork()
        ::'lambda'(uv_work_s*, int)
        ::operator()(uv_work_s*, int) const
        /work/node/out/../src/threadpoolwork-inl.h:57:15
    nodejs#10 node::ThreadPoolWork::ScheduleWork()
        ::'lambda'(uv_work_s*, int)
        ::__invoke(uv_work_s*, int)
        /work/node/out/../src/threadpoolwork-inl.h:48:7
    nodejs#11 uv__work_done /work/libuv-1.51.0/src/threadpool.c:330:5
    nodejs#12 uv__async_io.part.0
        /work/libuv-1.51.0/src/unix/async.c:208:5
```

Signed-off-by: ndossche <nora.dossche@ugent.be>
nodejs-github-bot pushed a commit that referenced this pull request Jun 2, 2026
@ndossche
src: fix edge case when deflateInit2() fails with Z_VERSION_ERROR …
458c37b 
This function call can fail with `Z_VERSION_ERROR` if the compiled
library vs loaded library mismatched in version number or in
stream structure size.
In those cases, zlib doesn't initialize the `strm_.msg` field to
null. Therefore, when a `CompressionError` object is created via
`ErrorForMessage()`, it can read a stale or uninitialized `strm_.msg`
pointer that will cause a crash.

Example ASAN report:
```
AddressSanitizer: SEGV on unknown address
    #0 __strlen_avx2
        string/../sysdeps/x86_64/multiarch/strlen-avx2.S:76
    #1 strlen (/work/node/out/Debug/node+0x1a42ab7)
    #2 v8::(anonymous namespace)::StringLength(char const*)
        /work/node/out/../deps/v8/src/api/api.cc:7581:16
    #3 v8::(anonymous namespace)::StringLength(unsigned char const*)
        /work/node/out/../deps/v8/src/api/api.cc:7587:10
    #4 v8::String::NewFromOneByte(v8::Isolate*,
        unsigned char const*, v8::NewStringType, int)
        /work/node/out/../deps/v8/src/api/api.cc:7677:3
    #5 node::OneByteString(v8::Isolate*,
        char const*, int, v8::NewStringType)
        /work/node/out/../src/util-inl.h:166:10
    #6 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::EmitError(node::(anonymous namespace)
        ::CompressionError const&)
        /work/node/out/../src/node_zlib.cc:565:7
    #7 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::CheckError()
        /work/node/out/../src/node_zlib.cc:519:5
    #8 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::AfterThreadPoolWork(int)
        /work/node/out/../src/node_zlib.cc:543:10
    #9 node::ThreadPoolWork::ScheduleWork()
        ::'lambda'(uv_work_s*, int)
        ::operator()(uv_work_s*, int) const
        /work/node/out/../src/threadpoolwork-inl.h:57:15
    #10 node::ThreadPoolWork::ScheduleWork()
        ::'lambda'(uv_work_s*, int)
        ::__invoke(uv_work_s*, int)
        /work/node/out/../src/threadpoolwork-inl.h:48:7
    #11 uv__work_done /work/libuv-1.51.0/src/threadpool.c:330:5
    #12 uv__async_io.part.0
        /work/libuv-1.51.0/src/unix/async.c:208:5
```

Signed-off-by: ndossche <nora.dossche@ugent.be>
PR-URL: #63476
Reviewed-By: Anna Henningsen <anna@addaleax.net>
cs01 added a commit to cs01/node that referenced this pull request Jun 10, 2026
@cs01
fs+test: flush option on writeFile/appendFile (sync/cb/promises) call… …
4acda72 
…ing fs.fsyncSync/fsync through module.exports so spies see it, ERR_INVALID_ARG_TYPE validation; node:test gets t.test subtests (inline, sequential, done-callback style), per-context t.mock with auto-restore, mock calls record error field; painpoints doc: nodejs#1/nodejs#2 marked resolved in milo compiler. fixes write-file-flush + append-file-flush, write/append cluster 13/13
aduh95 pushed a commit that referenced this pull request Jun 18, 2026
@ndossche @aduh95
src: fix edge case when deflateInit2() fails with Z_VERSION_ERROR …
d82d369 
This function call can fail with `Z_VERSION_ERROR` if the compiled
library vs loaded library mismatched in version number or in
stream structure size.
In those cases, zlib doesn't initialize the `strm_.msg` field to
null. Therefore, when a `CompressionError` object is created via
`ErrorForMessage()`, it can read a stale or uninitialized `strm_.msg`
pointer that will cause a crash.

Example ASAN report:
```
AddressSanitizer: SEGV on unknown address
    #0 __strlen_avx2
        string/../sysdeps/x86_64/multiarch/strlen-avx2.S:76
    #1 strlen (/work/node/out/Debug/node+0x1a42ab7)
    #2 v8::(anonymous namespace)::StringLength(char const*)
        /work/node/out/../deps/v8/src/api/api.cc:7581:16
    #3 v8::(anonymous namespace)::StringLength(unsigned char const*)
        /work/node/out/../deps/v8/src/api/api.cc:7587:10
    #4 v8::String::NewFromOneByte(v8::Isolate*,
        unsigned char const*, v8::NewStringType, int)
        /work/node/out/../deps/v8/src/api/api.cc:7677:3
    #5 node::OneByteString(v8::Isolate*,
        char const*, int, v8::NewStringType)
        /work/node/out/../src/util-inl.h:166:10
    #6 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::EmitError(node::(anonymous namespace)
        ::CompressionError const&)
        /work/node/out/../src/node_zlib.cc:565:7
    #7 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::CheckError()
        /work/node/out/../src/node_zlib.cc:519:5
    #8 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::AfterThreadPoolWork(int)
        /work/node/out/../src/node_zlib.cc:543:10
    #9 node::ThreadPoolWork::ScheduleWork()
        ::'lambda'(uv_work_s*, int)
        ::operator()(uv_work_s*, int) const
        /work/node/out/../src/threadpoolwork-inl.h:57:15
    #10 node::ThreadPoolWork::ScheduleWork()
        ::'lambda'(uv_work_s*, int)
        ::__invoke(uv_work_s*, int)
        /work/node/out/../src/threadpoolwork-inl.h:48:7
    #11 uv__work_done /work/libuv-1.51.0/src/threadpool.c:330:5
    #12 uv__async_io.part.0
        /work/libuv-1.51.0/src/unix/async.c:208:5
```

Signed-off-by: ndossche <nora.dossche@ugent.be>
PR-URL: #63476
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rvagg @indutny @bnoordhuis @siwenwang0803 @MikeBravoE