◐ Shell
reader mode source ↗
Skip to content

doc: add missing pull request number#27336

Closed
BridgeAR wants to merge 1 commit into
nodejs:masterfrom
BridgeAR:fix-changes-entry
Closed

doc: add missing pull request number#27336
BridgeAR wants to merge 1 commit into
nodejs:masterfrom
BridgeAR:fix-changes-entry

Conversation

@BridgeAR

@BridgeAR BridgeAR commented Apr 21, 2019

Copy link
Copy Markdown
Member

This adds a missing pull request number to the repl.md.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Apr 21, 2019

Copy link
Copy Markdown
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3318

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. repl Issues and PRs related to the REPL subsystem. labels Apr 21, 2019
@vsemozhetbyt

vsemozhetbyt commented Apr 21, 2019

Copy link
Copy Markdown
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 21, 2019
@vsemozhetbyt vsemozhetbyt mentioned this pull request Apr 21, 2019
Closed
4 tasks
@vsemozhetbyt

vsemozhetbyt commented Apr 21, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Is failing test due to a race condition with these PRs: #25947 and #27151 ?

@mscdex

mscdex commented Apr 21, 2019

Copy link
Copy Markdown
Contributor

This PR seems to add a lot more than just a PR number?

@BridgeAR

BridgeAR commented Apr 21, 2019

Copy link
Copy Markdown
Member Author

@mscdex I had to force push to master to fix a test and I did not yet update this PR (see the note about the force push). It's only about the second commit.

@BridgeAR BridgeAR force-pushed the fix-changes-entry branch from 421ee25 to 74adb9a Compare April 22, 2019 00:10
@BridgeAR

BridgeAR commented Apr 22, 2019

Copy link
Copy Markdown
Member Author

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3320/

@ZYSzys

ZYSzys commented Apr 24, 2019

Copy link
Copy Markdown
Member

@BridgeAR Seems that there are some conflicts need to be resolved.

@BridgeAR
doc: add missing pull request number …
ff0f181 
This adds a missing pull request number to the `repl.md`.
@BridgeAR BridgeAR force-pushed the fix-changes-entry branch from 74adb9a to ff0f181 Compare April 24, 2019 15:42
@BridgeAR

BridgeAR commented Apr 24, 2019

Copy link
Copy Markdown
Member Author

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3351/

BridgeAR added a commit to BridgeAR/node that referenced this pull request Apr 24, 2019
@BridgeAR
doc: fix pull request number …
237d9f9 
This fixes a pull request number in `repl.md`.

PR-URL: nodejs#27336
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@BridgeAR

BridgeAR commented Apr 24, 2019

Copy link
Copy Markdown
Member Author

Landed in 237d9f9 🎉

(I updated the description while landing since the PR number was actually set to a falsy value in the meanwhile).

@BridgeAR BridgeAR closed this Apr 24, 2019
targos pushed a commit that referenced this pull request Apr 27, 2019
@BridgeAR @targos
doc: fix pull request number …
453510c 
This fixes a pull request number in `repl.md`.

PR-URL: #27336
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@targos targos mentioned this pull request Apr 27, 2019
Merged
@BridgeAR BridgeAR deleted the fix-changes-entry branch January 20, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca

@tniessen tniessen tniessen approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

+2 more reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@mihalskiy mihalskiy mihalskiy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. repl Issues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@BridgeAR @nodejs-github-bot @vsemozhetbyt @mscdex @ZYSzys @addaleax @benjamingr @lpinca @tniessen @mihalskiy