{{ message }}
Closed
Conversation
Sorry, something went wrong.
nodejs-github-bot
added
the
dgram
Issues and PRs related to the dgram subsystem / UDP.
label
Apr 22, 2019
Contributor
|
The subsystem in the commit message should be |
Sorry, something went wrong.
The function 'isConnected' is directly called by many 'Socket' instance, so we shouldn't directly use 'this' because 'this' will be the self of function itself, and we should use 'self' as the instance of 'Socket' function.
ghost
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
santigimeno
approved these changes
Apr 22, 2019
Member
Sorry, something went wrong.
joyeecheung
approved these changes
Apr 22, 2019
lpinca
approved these changes
Apr 22, 2019
cjihrig
approved these changes
Apr 22, 2019
fhinkel
approved these changes
Apr 22, 2019
ZYSzys
approved these changes
Apr 22, 2019
ZYSzys
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Apr 22, 2019
benjamingr
approved these changes
Apr 22, 2019
Member
|
Landed in 1a54d0f |
Sorry, something went wrong.
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 24, 2019
The function 'isConnected' is directly called by many 'Socket' instance, so we shouldn't directly use 'this' because 'this' will be the self of function itself, and we should use 'self' as the instance of 'Socket' function. PR-URL: nodejs#27338 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
ghost
deleted the
Author
|
Thanks all! |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Apr 27, 2019
The function 'isConnected' is directly called by many 'Socket' instance, so we shouldn't directly use 'this' because 'this' will be the self of function itself, and we should use 'self' as the instance of 'Socket' function. PR-URL: #27338 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
The function 'isConnected' is directly called by many 'Socket' instance functions, so we shouldn't directly use 'this' because 'this' will be the self of function itself, and we should use 'self' as the instance of 'Socket' function.
make -j4 test(UNIX), orvcbuild test(Windows) passes