{{ message }}
util: improve symbol to string tag#27342
Closed
BridgeAR wants to merge 2 commits into
Closed
Conversation
Member
Sorry, something went wrong.
Only special handle `Symbol.toStringTag` if the property is not enumerable or not the own property of the inspected object.
The function is actually a getter, not a setter.
Collaborator
Sorry, something went wrong.
nodejs-github-bot
added
the
util
Issues and PRs related to the built-in util module.
label
Apr 22, 2019
benjamingr
approved these changes
Apr 22, 2019
benjamingr
left a comment
benjamingr
left a comment
Member
There was a problem hiding this comment.
Nice change
Sorry, something went wrong.
addaleax
approved these changes
Apr 22, 2019
BridgeAR
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Apr 22, 2019
Collaborator
Sorry, something went wrong.
Member
|
i'm feeling aggressively neutral about this |
Sorry, something went wrong.
Contributor
Sorry, something went wrong.
danbev
pushed a commit
that referenced
this pull request
Apr 25, 2019
The function is actually a getter, not a setter. PR-URL: #27342 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Apr 27, 2019
Only special handle `Symbol.toStringTag` if the property is not enumerable or not the own property of the inspected object. PR-URL: #27342 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Apr 27, 2019
The function is actually a getter, not a setter. PR-URL: #27342 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
To reduce redundancy use the
Symbol.toStringTagonly if otherwise not visible.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes