{{ message }}
doc: move v8.getHeapCodeStatistics()#36027
Merged
Trott merged 1 commit intoNov 10, 2020
Merged
Conversation
Member
Sorry, something went wrong.
aduh95
approved these changes
Nov 7, 2020
benjamingr
approved these changes
Nov 7, 2020
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Nov 7, 2020
github-actions
Bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 9, 2020
14 tasks
Move v8.getHeapCodeStatistics() to its alphabetic location in the docs. An effort to alphabetize all the entries met some resistance on the grounds that it put some things in an order that wasn't logical, but this one should be uncontroversial, I think. PR-URL: nodejs#36027 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Trott
force-pushed
the
v8-partial-alpha
branch
from
23e7fe6 to
270a02c
Compare
November 10, 2020 13:29
danielleadams
pushed a commit
that referenced
this pull request
Nov 10, 2020
Move v8.getHeapCodeStatistics() to its alphabetic location in the docs. An effort to alphabetize all the entries met some resistance on the grounds that it put some things in an order that wasn't logical, but this one should be uncontroversial, I think. PR-URL: #36027 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 9, 2020
Move v8.getHeapCodeStatistics() to its alphabetic location in the docs. An effort to alphabetize all the entries met some resistance on the grounds that it put some things in an order that wasn't logical, but this one should be uncontroversial, I think. PR-URL: #36027 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
Move v8.getHeapCodeStatistics() to its alphabetic location in the docs. An effort to alphabetize all the entries met some resistance on the grounds that it put some things in an order that wasn't logical, but this one should be uncontroversial, I think. PR-URL: #36027 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Move v8.getHeapCodeStatistics() to its alphabetic location in the docs.
An effort to alphabetize all the entries met some resistance on the
grounds that it put some things in an order that wasn't logical, but
this one should be uncontroversial, I think.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes