Implement the negative_array_index RFC#3772
Conversation
Sorry, something went wrong.
pmmaga
force-pushed
the
negative-next-index-8
branch
from
e2c2f6a to
142a0e3
Compare
January 30, 2019 18:06
|
Now that I noticed that we don't have the |
Sorry, something went wrong.
pmmaga
force-pushed
the
negative-next-index-8
branch
from
1987fca to
92f3541
Compare
February 4, 2019 17:22
|
Not sure if we'll be using milestones for other cases as well. If yes, we will probably need that. |
Sorry, something went wrong.
|
@carusogabriel We don't really use Github fully so things like Milestones are not a thing here. I believe we did tag PRs for versions at one point, but I could be wrong |
Sorry, something went wrong.
|
@carusogabriel I've added you to the GH org. Generally, it's best not to manage labels via the QA interface, as the generated notifications are annoying to everyone else. |
Sorry, something went wrong.
pmmaga
force-pushed
the
negative-next-index-8
branch
from
92f3541 to
9eee682
Compare
February 6, 2019 17:40
pmmaga
force-pushed
the
negative-next-index-8
branch
from
9eee682 to
319fddf
Compare
February 6, 2019 17:46
|
looks fine for me too. |
Sorry, something went wrong.
The `nNextFreeElement` field is initialized with `ZEND_LONG_MIN` instead of zero since PHP 8.0. Adjust our `php_mp_is_hash()` check accordingly. See [1] and [2] for details. NB: PHP 8.1 introduces `zend_array_is_list()`, which may be used here. See [3] and [4] for details. [1]: https://wiki.php.net/rfc/negative_array_index [2]: php/php-src#3772 [3]: https://wiki.php.net/rfc/is_list [4]: php/php-src#6070 Since I don't observe any other problems on PHP 8.1, closing the relevant issue. Fixes tarantool#171
The `nNextFreeElement` field is initialized with `ZEND_LONG_MIN` instead of zero since PHP 8.0. Adjust our `php_mp_is_hash()` check accordingly. See [1] and [2] for details. NB: PHP 8.1 introduces `zend_array_is_list()`, which may be used here. See [3] and [4] for details. [1]: https://wiki.php.net/rfc/negative_array_index [2]: php/php-src#3772 [3]: https://wiki.php.net/rfc/is_list [4]: php/php-src#6070 Since I don't observe any other problems on PHP 8.1, closing the relevant issue. Fixes #171
Implementation for https://wiki.php.net/rfc/negative_array_index