{{ message }}
Add support for julia hooks#3348
Merged
asottile merged 1 commit intoNov 25, 2024
Merged
Conversation
Contributor
Sorry, something went wrong.
fredrikekre
added a commit
to fredrikekre/pre-commit.com
that referenced
this pull request
Nov 1, 2024
See pre-commit PR: pre-commit/pre-commit#3348
fredrikekre
force-pushed
the
fe/julia
branch
2 times, most recently
from
bc41985 to
54d9104
Compare
November 3, 2024 01:13
asottile
reviewed
Nov 9, 2024
fredrikekre
force-pushed
the
fe/julia
branch
from
eb5ea96 to
631aaf3
Compare
November 10, 2024 00:32
This patch adds 2nd class support for hooks using julia as the language. pre-commit will install any dependencies defined in the hooks repo `Project.toml` file, with support for `additional_dependencies` as well. Julia doesn't (yet) have a way to install binaries/scripts so for julia hooks the `entry` value is a (relative) path to a julia script within the hooks repository. When executing a julia hook the (globally installed) julia interpreter is prepended to the entry. Example `.pre-commit-hooks.yaml`: ```yaml - id: foo name: ... language: julia entry: bin/foo.jl --arg1 ``` Example hooks repo: https://github.com/fredrikekre/runic-pre-commit/tree/fe/julia Accompanying pre-commit.com PR: pre-commit/pre-commit.com#998 Fixes pre-commit#2689.
asottile
approved these changes
Nov 25, 2024
asottile
left a comment
asottile
left a comment
Member
There was a problem hiding this comment.
very cool! thanks for working on this :D
Sorry, something went wrong.
fredrikekre
added a commit
to fredrikekre/pre-commit.com
that referenced
this pull request
Nov 26, 2024
See pre-commit PR: pre-commit/pre-commit#3348
Contributor
Author
|
Thanks for the review and merge! I have updated pre-commit/pre-commit.com#998 to match the final implementation here. |
Sorry, something went wrong.
fredrikekre
added a commit
to fredrikekre/pre-commit.com
that referenced
this pull request
Nov 26, 2024
See pre-commit PR: pre-commit/pre-commit#3348
Contributor
Author
|
@asottile just out of curiosity, is there a timeline for a new release (4.1.0?) that includes this feature? Thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
This patch adds 2nd class support for hooks using julia as the language. pre-commit will install any dependencies defined in the hooks repo
Project.tomlfile, with support foradditional_dependenciesas well. Julia doesn't (yet) have a way to install binaries/scripts so for julia hooks theentryvalue is a (relative) path to a julia script within the hooks repository. When executing a julia hook the (globally installed) julia interpreter is prepended to the entry.Example
.pre-commit-hooks.yaml:Example hooks repo: https://github.com/fredrikekre/runic-pre-commit/tree/fe/julia
Accompanying pre-commit.com PR: pre-commit/pre-commit.com#998
Fixes #2689.