◐ Shell
reader mode source ↗
Skip to content

feat: Add --no-fail-fast CLI option to override fail-fast behavior#3710

Closed
anthonyhaussman wants to merge 1 commit into
pre-commit:mainfrom
anthonyhaussman:tone/feat/no-fail-fast
Closed

feat: Add --no-fail-fast CLI option to override fail-fast behavior#3710
anthonyhaussman wants to merge 1 commit into
pre-commit:mainfrom
anthonyhaussman:tone/feat/no-fail-fast

Conversation

@anthonyhaussman

Copy link
Copy Markdown

Introduce a mutually exclusive --no-fail-fast CLI argument alongside --fail-fast.

This option allows disabling fail-fast behavior even if it has been enabled globally in the config or at the individual hook level.
Also update hook-impl to safely support the no_fail_fast attribute.

Introduce a mutually exclusive --no-fail-fast CLI argument alongside --fail-fast. This option allows disabling fail-fast behavior even if it has been enabled globally in the config or at the individual hook level. Also update hook-impl to safely support the no_fail_fast attribute.

Assisted-by: Gemini 3.5 Flash
@asottile

Copy link
Copy Markdown
Member

I don't think this is a good idea. if it's misconfigured just fix the config

@asottile asottile closed this Jun 15, 2026
@anthonyhaussman

Copy link
Copy Markdown
Author

Well, the goal was to enable fail-fast in the configuration file for local execution, but run the CI steps with --no-fail-fast.

But I'll find another way. 🙏

@anthonyhaussman anthonyhaussman deleted the tone/feat/no-fail-fast branch June 15, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants