◐ Shell
reader mode source ↗
Skip to content

maven to maven-publish#635

Merged
codeanticode merged 12 commits into
processing:masterfrom
rupeshkumar22:mavenPublish
Apr 25, 2021
Merged

maven to maven-publish#635
codeanticode merged 12 commits into
processing:masterfrom
rupeshkumar22:mavenPublish

Conversation

@rupeshkumar22

@rupeshkumar22 rupeshkumar22 commented Jan 5, 2021

Copy link
Copy Markdown
Contributor

Fixes #623
Maven plugin is completely removed and replaced by the new maven-publish plugin. Creates pom files in respected dist folders. The pom files are copied from build/publications/pub-name/pom-default.xml to the dist directory.
Usage

  • Creation of pom-default.xml files at locations:
    root/core/build/publications/corePublication/pom-default.xml
    root/mode/libraries/ar/build/publications/arPublication/pom-default.xml
    root/mode/libraries/vr/build/publications/vrPublication/pom-default.xml

  • Commands to generate these files are:
    gradle generatePomFileForcorePublicationPublication
    gradle generatePomFileForarPublicationPublication
    gradle generatePomFileForvrPublicationPublication

Before executing Gradle build, Either the above commands need to be executed one by one or combined as:

gradle generatePomFileForcorePublicationPublication generatePomFileForarPublicationPublication generatePomFileForvrPublicationPublication build

The error will be handled with the instructions in case if 'gradle build' is executed before the creation of pom files as follows:

erhandled

@codeanticode

Copy link
Copy Markdown
Contributor

@rupesh-kumar-lpu thanks a lot for this PR! I will review and merge into the next release of the mode.

@rupeshkumar22

Copy link
Copy Markdown
Contributor Author

@codeanticode thanks for your valuable response! Changes are there in three 'build.gradle' files (Core, AR, and VR). Some of the commits are changed again and again making the PR a bit unordered to review. You may review the code directly from the forked maven-publish branch, related to this PR. If there is a need I can create a separate squash and merge PR. Thanks!

@rupeshkumar22

Copy link
Copy Markdown
Contributor Author

@ranaaditya The changes have been done. I'll keep in mind using relevant variable names as you suggested, thanks for correcting!

@codeanticode codeanticode merged commit 9ac5869 into processing:master Apr 25, 2021
@rupeshkumar22 rupeshkumar22 deleted the mavenPublish branch April 30, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to maven-publish plugin

3 participants