◐ Shell
reader mode source ↗
Skip to content

SDKUpdater Improvements#713

Merged
codeanticode merged 6 commits into
processing:sdkupdater-improvement-testingfrom
rupeshkumar22:SDKUpdaterImprovements
Dec 31, 2022
Merged

SDKUpdater Improvements#713
codeanticode merged 6 commits into
processing:sdkupdater-improvement-testingfrom
rupeshkumar22:SDKUpdaterImprovements

Conversation

@rupeshkumar22

@rupeshkumar22 rupeshkumar22 commented Nov 4, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #666, #718

The PR introduces the following changes-

  • Progress Bar has been set to determine mode with percentage progress
  • A new secondary status has been added for process details
  • UI has been improved(Action Button was not showing the full text)
  • Size reduction: Only the necessary jar files have been included in AndroidMode's final zip. Also, runtime testing has been done to make sure only necessary jars are included rest are excluded with exclude statements in SDKUpdater/build.xml Including all the jars costs 50+ MB in total for AndroidMode.zip which has been reduced to approx 32 MB.
  • Removed java modules in java 17 have been supported with necessary jars.(SDK Updater crahes with 'java.lang.NoClassDefFoundError: javax/xml/bind/annotation/XmlSchema' error #666)
  • android-toolslib has been updated to 30.3.0 from 27.1.1 and corresponding methods (i.e AndroidSDKHandler) have been updated accordingly.
  • Now a CustomProgressIndicatorToMonitor class is being used and with the help of its overridden methods, we are able to reflect the progress on UI.

SDKUpdaterPR

An outcome of Google Summer of Code 2022
Author - Rupesh Kumar @rupeshkumar22
Mentor - Aditya Rana @ranaaditya
Project Lead(Processing For Android) - Andrés Colubri @codeanticode

@ranaaditya

ranaaditya commented Dec 14, 2022

Copy link
Copy Markdown
Member

Hi @codeanticode , can you please review this PR and merge it.

Thanks !

@rupeshkumar22

rupeshkumar22 commented Dec 18, 2022

Copy link
Copy Markdown
Contributor Author

Better to use only include *.jar statements. So adding one more commit for SDKUpdater.

@rupeshkumar22

rupeshkumar22 commented Dec 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I'm resolving Issue #718 as a part of this PR So that there won't be any PR conflict issues.

@rupeshkumar22

rupeshkumar22 commented Dec 18, 2022

Copy link
Copy Markdown
Contributor Author

Testing has been done from my side after applying the new changes. Also checked the updater again. Tried installing SDK with the updater. No issue has been faced.
Also, Fixed #718

@codeanticode codeanticode changed the base branch from master to sdkupdater-improvement-testing December 31, 2022 19:03
@codeanticode

codeanticode commented Dec 31, 2022

Copy link
Copy Markdown
Contributor

@rupeshkumar22 Thank you for the PR, I'm merging into a separate branch for testing before making the new release. Happy New Year :-)

@codeanticode codeanticode reopened this Dec 31, 2022
@codeanticode codeanticode merged commit 66e563f into processing:sdkupdater-improvement-testing Dec 31, 2022
@rupeshkumar22

rupeshkumar22 commented Jan 8, 2023

Copy link
Copy Markdown
Contributor Author

@codeanticode Happy New Year! thanks :)

@rupeshkumar22 rupeshkumar22 mentioned this pull request Jan 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ranaaditya ranaaditya ranaaditya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SDK Updater crahes with 'java.lang.NoClassDefFoundError: javax/xml/bind/annotation/XmlSchema' error

3 participants

@rupeshkumar22 @ranaaditya @codeanticode