◐ Shell
reader mode source ↗
Skip to content

added describe to directional light and color variable example#447

Merged
SableRaf merged 5 commits into
processing:mainfrom
yogitheboss:main
Jul 30, 2024
Merged

added describe to directional light and color variable example#447
SableRaf merged 5 commits into
processing:mainfrom
yogitheboss:main

Conversation

@yogitheboss

@yogitheboss yogitheboss commented Feb 24, 2023

Copy link
Copy Markdown
Contributor

this addresses issue #312

SableRaf
SableRaf requested changes Feb 27, 2023
View reviewed changes

@SableRaf SableRaf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Hello @yogitheboss, thank you for your contribution! The text content of the describe() function is great.

We kindly request that you add the describe() function to the liveSketch.js examples rather than the .pde files. You can find an explanation here. The describe() function is only available in p5.js, not in Processing. The purpose of this change is to ensure that interactive examples are properly described for users who rely on screen readers.

Please don't hesitate to ask if you have any questions or concerns. Thank you again for your valuable contribution!

@yogitheboss

yogitheboss commented Feb 27, 2023

Copy link
Copy Markdown
Contributor Author

Ok @SableRaf , now i got it.
I should have checked the readme file.
I will make the necessary changes and submit the pull request again.

@SableRaf

SableRaf commented May 30, 2023

Copy link
Copy Markdown
Collaborator

Hey @yogitheboss,

Just checking in on the describe() changes for the liveSketch.js examples. Noticed it's been a while since we last touched base on this. When you get a chance, could you update and resubmit the PR? Let me know if you need any help.

Thanks!

@SableRaf SableRaf mentioned this pull request Sep 4, 2023
Open
@netlify

netlify Bot commented Feb 2, 2024 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for processing-faf822 ready!

Name Link
🔨 Latest commit f32e706
🔍 Latest deploy log https://app.netlify.com/sites/processing-faf822/deploys/65bd05ac2c59780007ce3a6b
😎 Deploy Preview https://deploy-preview-447--processing-faf822.netlify.app/examples/saturation
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SableRaf SableRaf merged commit d193e1b into processing:main Jul 30, 2024
@SableRaf

SableRaf commented Jul 30, 2024

Copy link
Copy Markdown
Collaborator

Thanks @yogitheboss for your contribution! ✨ It's a wonderful step in making the Processing website a bit more accessible. If you would like to make further alt-text contributions I'll make sure to get those merged a little faster next time 😉

@SableRaf SableRaf mentioned this pull request Jul 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SableRaf SableRaf SableRaf requested changes

@Stefterv Stefterv Stefterv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yogitheboss @SableRaf @Stefterv