{{ message }}
fixes error highlighting when selecting an error in another tab#1114
Merged
SableRaf merged 2 commits intoJul 11, 2025
Merged
Conversation
Contributor
Sorry, something went wrong.
fixes bug with selecting an error that's in a tab that isn't visible yet.
Stefterv
approved these changes
May 22, 2025
Hide details
View details
SableRaf
merged commit
SableRaf
merged commit a58a7a7
into
processing:main
Jul 11, 2025
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer
3 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Fixes #1112
Current code finds start/end of highlight by finding char offsets based on the error's given line number; however, it's looking at the visible tab to do so, making the highlighting go wonky if you're selecting an error in a tab you don't have open yet.
Added one line to switch active tab before we find the char offsets.