Refactoring SketchException to be available outside of app#1196
Conversation
|
Hi @joshgiesbrecht, thank you again for your work on this! I just ran your branch locally and it breaks Android mode since it is looking for the SketchException class but cannot find it within the |
Sorry, something went wrong.
…ly refactored one, so alternate modes don't break.
|
I think we're good to go now. I wrote a new, very tiny processing.app.SketchException that extends the utils one, so not only does it allow other modes to work but it still plays nicely when testing if something is a processing.utils.SketchException. Once this is released, I'll submit changes to the other modes so they refer directly to the utils class, and when those are released then I'll come back and delete the extra file. Hopefully. Fingers crossed. 😆 |
Sorry, something went wrong.
|
Thank you @joshgiesbrecht! Not sure if the |
Sorry, something went wrong.
|
Deprecated marked. I didn't expect the wrappers would be necessary either, but Idea complained and said it was a compile problem, so I let it generate them. 🤷 |
Sorry, something went wrong.
|
Not sure how to connect this PR in github to the issue, but it's resolving issue #1153 |
Sorry, something went wrong.
catilac
left a comment
There was a problem hiding this comment.
This looks good to me. Please document your plan a bit in the file since it'll be around for a bit, and I'll approve!
Sorry, something went wrong.
catilac
left a comment
There was a problem hiding this comment.
Going to approve. We'll have to come up with a plan for communicating the change to other project maintainers.
Sorry, something went wrong.
198f593
into
processing:main
Aug 28, 2025
Refactored SketchException to live in :app:utils, as per discussion in draft PR #1164. (resubmitted because that draft PR turned into an all-out mess of unrelated commits somehow)
Before merge:
AntCloses #1153