◐ Shell
reader mode source ↗
Skip to content

New links in "Help" menu for issues and forum #1210

Merged
catilac merged 5 commits into
processing:mainfrom
lassevonpfeil:main
Aug 22, 2025
Merged

New links in "Help" menu for issues and forum #1210
catilac merged 5 commits into
processing:mainfrom
lassevonpfeil:main

Conversation

@lassevonpfeil

Copy link
Copy Markdown
Contributor

Added two links to the help menu bar. Opens either processing forum or GitHub issues tab in standard browser when clicked. Resolves Issue #1208
Implemented the new features in JavaEditor.java and also provided German language support.
Used Desktop.getDesktop() and then Desktop.browse(oURL) to follow the link.
I Placed the MenuItems between "Download official reference" and "library reference".

I will change the code ASAP when somethings bugging or the I messed up with the style guidelines.

@lassevonpfeil

Copy link
Copy Markdown
Contributor Author

Added no tests btw. Works bug-free on MacOS 15.6 and should work universally.

@lassevonpfeil lassevonpfeil changed the title New links in "Help" menu for issues and forum #1208 Aug 15, 2025
@SableRaf SableRaf requested a review from catilac August 20, 2025 11:43

@catilac catilac left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Hi! Great work on this! I am curious about which version of Java you are using. We use Eclipse Temurin 17. I believe if you set that SDK then you will see that desktop.browse() will throw an exception.

here is an example in the file of the pattern you'll want to follow:

    item = new JMenuItem(Language.text("menu.help.getting_started"));
    item.addActionListener(e -> Platform.openURL(Language.text("menu.help.getting_started.url")));
    menu.add(item);

@lassevonpfeil lassevonpfeil left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Changed used method to Platform.openURL(). Should now work universally.

@lassevonpfeil lassevonpfeil left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Okay, removed the imports now. I personally think it looks good now. But of course I would love to make some changes if needed.

@catilac catilac left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thank you!

Hide details View details @catilac catilac merged commit e02ef2e into processing:main Aug 22, 2025
6 checks passed
catilac added a commit that referenced this pull request Aug 28, 2025
Updated URL Mistake for PR #1210 and Issue #1208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants